Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: implement the scheduling rule watcher #6878

Merged
merged 2 commits into from Aug 3, 2023
Merged

*: implement the scheduling rule watcher #6878

merged 2 commits into from Aug 3, 2023

Conversation

JmPotato
Copy link
Member

@JmPotato JmPotato commented Aug 2, 2023

What problem does this PR solve?

Issue Number: ref #5839.

What is changed and how does it work?

- Implement the scheduling rule watcher.
- Add the tests.
- Refine some code.

Check List

Tests

  • Unit test
  • Integration test

Release note

None.

@JmPotato JmPotato added component/schedule Scheduling logic. component/placement Placement rule. labels Aug 2, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 2, 2023 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lhy1024
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added release-note-none size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 2, 2023
@codecov
Copy link

codecov bot commented Aug 2, 2023 •
edited

Codecov Report

Merging #6878 (cf8bf5b) into master (6377b26) will increase coverage by 0.19%.
The diff coverage is 82.70%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #6878      +/-   ##
==========================================
+ Coverage   74.12%   74.31%   +0.19%     
==========================================
  Files         427      428       +1     
  Lines       44974    45088     +114     
==========================================
+ Hits        33335    33508     +173     
+ Misses       8683     8636      -47     
+ Partials     2956     2944      -12
Flag Coverage Δ
unittests 74.31% <82.70%> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 2, 2023
@JmPotato
Implement the scheduling rule watcher
b56a78b 
Signed-off-by: JmPotato <ghzpotato@gmail.com>
@JmPotato
Add startWatcher into startServer
cf8bf5b 
Signed-off-by: JmPotato <ghzpotato@gmail.com>
@JmPotato JmPotato requested a review from rleungx August 3, 2023 03:17
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 3, 2023
@JmPotato
Copy link
Member Author

JmPotato commented Aug 3, 2023

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 3, 2023

@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 3, 2023

This pull request has been accepted and is ready to merge.

Commit hash: cf8bf5b

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 3, 2023
@ti-chi-bot ti-chi-bot bot merged commit 27a3cc5 into tikv:master Aug 3, 2023
26 checks passed
@JmPotato JmPotato deleted the scheduling_pr_watch branch August 3, 2023 03:57
@JmPotato JmPotato mentioned this pull request Aug 3, 2023
Closed
rleungx pushed a commit to rleungx/pd that referenced this pull request Dec 1, 2023
@JmPotato @rleungx
*: implement the scheduling rule watcher (tikv#6878)
9093c2d 
ref tikv#5839

- Implement the scheduling rule watcher.
- Add the tests.
- Refine some code.

Signed-off-by: JmPotato <ghzpotato@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhy1024 lhy1024 lhy1024 approved these changes

@rleungx rleungx rleungx approved these changes

Assignees
No one assigned
Labels
component/placement Placement rule. component/schedule Scheduling logic. release-note-none size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JmPotato @lhy1024 @rleungx