Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: remove check-plugin from the static checks #6887

Merged
merged 1 commit into from Aug 3, 2023

Conversation

JmPotato
Copy link
Member

@JmPotato JmPotato commented Aug 3, 2023

What problem does this PR solve?

Issue Number: ref #4399.

What is changed and how does it work?

Since the plugin feature is hardly used and may be very time-consuming in the Gtihub Actions CI,
this PR removes it from `make check`.

Check List

Tests

  • Unit test
  • Integration test

Release note

None.

Signed-off-by: JmPotato <ghzpotato@gmail.com>
@JmPotato JmPotato added component/testing CI testing. require-LGT1 Indicates that the PR requires an LGTM. labels Aug 3, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 3, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lhy1024

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added release-note-none size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 3, 2023
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 3, 2023
@JmPotato
Copy link
Member Author

JmPotato commented Aug 3, 2023

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 3, 2023

@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 3, 2023

This pull request has been accepted and is ready to merge.

Commit hash: c821a98

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 3, 2023
@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Merging #6887 (c821a98) into master (27a3cc5) will increase coverage by 0.15%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6887      +/-   ##
==========================================
+ Coverage   74.05%   74.21%   +0.15%     
==========================================
  Files         428      428              
  Lines       45088    45088              
==========================================
+ Hits        33390    33460      +70     
+ Misses       8737     8674      -63     
+ Partials     2961     2954       -7     
Flag Coverage Δ
unittests 74.21% <ø> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot merged commit c8c5e1e into tikv:master Aug 3, 2023
27 checks passed
@JmPotato JmPotato deleted the remove_check_plugin branch August 3, 2023 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/testing CI testing. release-note-none require-LGT1 Indicates that the PR requires an LGTM. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants