Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scheduling/config: watch StoreConfig in scheduling config watcher #6921

Merged
merged 1 commit into from Aug 9, 2023
Merged

scheduling/config: watch StoreConfig in scheduling config watcher #6921

merged 1 commit into from Aug 9, 2023

Conversation

JmPotato
Copy link
Member

@JmPotato JmPotato commented Aug 9, 2023

What problem does this PR solve?

Issue Number: ref #5839

What is changed and how does it work?

Watch `StoreConfig` in scheduling config watcher.

Check List

Tests

  • Unit test
  • Integration test

Release note

None.

@JmPotato
Watch StoreConfig in scheduling config watcher
735b1cb 
Signed-off-by: JmPotato <ghzpotato@gmail.com>
@JmPotato JmPotato added component/schedule Scheduling logic. component/config Configuration logic. require-LGT1 Indicates that the PR requires an LGTM. labels Aug 9, 2023
@JmPotato JmPotato requested a review from rleungx August 9, 2023 07:17
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 9, 2023 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added release-note-none size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 9, 2023
@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Merging #6921 (735b1cb) into master (d4138c8) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #6921      +/-   ##
==========================================
- Coverage   74.31%   74.26%   -0.05%     
==========================================
  Files         427      427              
  Lines       45144    45149       +5     
==========================================
- Hits        33550    33532      -18     
- Misses       8642     8660      +18     
- Partials     2952     2957       +5
Flag Coverage Δ
unittests 74.26% <100.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 9, 2023
@JmPotato
Copy link
Member Author

JmPotato commented Aug 9, 2023

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 9, 2023

@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 9, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 735b1cb

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 9, 2023
@ti-chi-bot ti-chi-bot bot merged commit 68a3e95 into tikv:master Aug 9, 2023
27 checks passed
@JmPotato JmPotato deleted the sync_store_config branch August 9, 2023 07:55
@rleungx rleungx mentioned this pull request Aug 24, 2023
Closed
rleungx pushed a commit to rleungx/pd that referenced this pull request Dec 1, 2023
@JmPotato @rleungx
scheduling/config: watch StoreConfig in scheduling config watcher (ti…
516a1ba 
…kv#6921)

ref tikv#5839

Watch `StoreConfig` in scheduling config watcher.

Signed-off-by: JmPotato <ghzpotato@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rleungx rleungx rleungx approved these changes

Assignees
No one assigned
Labels
component/config Configuration logic. component/schedule Scheduling logic. release-note-none require-LGT1 Indicates that the PR requires an LGTM. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JmPotato @rleungx