mcs: support region http interface in scheduling server #7297

lhy1024 · 2023-11-01T13:56:06Z

What problem does this PR solve?

Issue Number: Ref #5839

What is changed and how does it work?

Check List

Tests

Unit test

Release note

None.

Signed-off-by: lhy1024 <admin@liudos.us>

ti-chi-bot · 2023-11-01T13:56:08Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

CabinfeverB
rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

ti-chi-bot · 2023-11-01T13:56:09Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

rleungx · 2023-11-10T06:26:50Z

pkg/mcs/scheduling/server/apis/v1/api.go

+
+// RegisterRegionLabelRouter registers the router of the region label handler.
+func (s *Service) RegisterRegionLabelRouter() {
+	router := s.root.Group("config/region-label")


Shall we add a sub group in config?

yes, I will do it. The code is written before config pr merged.

Signed-off-by: lhy1024 <admin@liudos.us>

rleungx · 2023-11-21T04:01:57Z

Is it ready to review?

lhy1024 · 2023-11-21T04:10:13Z

Is it ready to review?

I am moving test, it will be ready to review today.

Signed-off-by: lhy1024 <admin@liudos.us>

lhy1024 · 2023-11-21T10:40:41Z

tests/server/api/region_test.go

+			conf.Replication.EnablePlacementRules = true
+		})
+	// FIXME: enable this test in two modes.
+	env.RunTestInPDMode(suite.checkRegionsReplicated)


This seem to be a new bug. BTW, we need to fix below test.

it always try to add rule peer, maybe there is a problem in placement rule sync

I will do it in another pr #7418

Signed-off-by: lhy1024 <admin@liudos.us>

lhy1024 · 2023-11-22T04:22:01Z

pkg/utils/apiutil/serverapi/middleware.go

 			if rule.filter != nil && !rule.filter(r) {
 				continue
 			}
-			origin := r.URL.Path
+			// we check the service primary addr here, so no need to check independently again.


Is it right? cc @rleungx

Yes, because the check service is used to manage service dynamically and tso is not supported now.

Signed-off-by: lhy1024 <admin@liudos.us>

codecov · 2023-11-22T18:24:04Z

Codecov Report

Merging #7297 (b777d28) into master (9902be8) will decrease coverage by 0.18%.
The diff coverage is 58.45%.

❗ Current head b777d28 differs from pull request most recent head f1115f6. Consider uploading reports for the commit f1115f6 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #7297      +/-   ##
==========================================
- Coverage   74.32%   74.15%   -0.18%     
==========================================
  Files         451      451              
  Lines       49387    49526     +139     
==========================================
+ Hits        36709    36726      +17     
- Misses       9417     9497      +80     
- Partials     3261     3303      +42

Flag	Coverage Δ
unittests	`74.15% <58.45%> (-0.18%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

lhy1024 · 2023-11-23T09:08:17Z

/merge

ti-chi-bot · 2023-11-23T09:08:19Z

@lhy1024: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2023-11-23T09:08:20Z

This pull request has been accepted and is ready to merge.

Commit hash: 8a6f56d

Signed-off-by: lhy1024 <admin@liudos.us>

lhy1024 · 2023-11-23T18:15:35Z

/merge

ti-chi-bot · 2023-11-23T18:15:37Z

@lhy1024: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2023-11-23T18:15:39Z

This pull request has been accepted and is ready to merge.

Commit hash: b777d28

ti-chi-bot · 2023-11-23T18:15:53Z

@lhy1024: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ref tikv#5839 Signed-off-by: lhy1024 <admin@liudos.us> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>

lhy1024 added 2 commits October 27, 2023 19:12

mcs: support region label http interface in scheduling server

0452c63

Signed-off-by: lhy1024 <admin@liudos.us>

mcs: support region http interface in scheduling server

37c3c76

Signed-off-by: lhy1024 <admin@liudos.us>

ti-chi-bot bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 1, 2023

ti-chi-bot bot added the release-note-none label Nov 1, 2023

ti-chi-bot bot requested review from disksing and nolouch November 1, 2023 13:56

ti-chi-bot bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Nov 1, 2023

lhy1024 mentioned this pull request Nov 1, 2023

mcs: forward request to scheduling server #7178

Closed

25 tasks

rleungx reviewed Nov 10, 2023

View reviewed changes

ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 17, 2023

Merge branch 'master' of github.com:tikv/pd into sche-redirect11

503a6d4

Signed-off-by: lhy1024 <admin@liudos.us>

ti-chi-bot bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 20, 2023

update api.go

2b06e2f

Signed-off-by: lhy1024 <admin@liudos.us>

lhy1024 added 3 commits November 21, 2023 17:05

fix test

07e96f0

Signed-off-by: lhy1024 <admin@liudos.us>

Merge branch 'master' of github.com:tikv/pd into sche-redirect11

d2d30bc

move test

0dfc784

Signed-off-by: lhy1024 <admin@liudos.us>

lhy1024 commented Nov 21, 2023

View reviewed changes

lhy1024 force-pushed the sche-redirect11 branch from 8d72880 to 56e08d7 Compare November 21, 2023 10:52

lhy1024 requested review from rleungx, JmPotato and CabinfeverB November 21, 2023 10:56

lhy1024 marked this pull request as ready for review November 21, 2023 10:56

ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 21, 2023

make TestGetAllByKey stable

11c72ac

Signed-off-by: lhy1024 <admin@liudos.us>

lhy1024 force-pushed the sche-redirect11 branch from 88bcd4a to 11c72ac Compare November 21, 2023 17:25

fix test

45f1541

Signed-off-by: lhy1024 <admin@liudos.us>

lhy1024 commented Nov 22, 2023

View reviewed changes

lhy1024 added 4 commits November 22, 2023 17:36

remove redundant route

68b58a9

Signed-off-by: lhy1024 <admin@liudos.us>

test

c106431

Signed-off-by: lhy1024 <admin@liudos.us>

Merge branch 'master' of github.com:tikv/pd into sche-redirect11

e5c4518

make test stable

8a6f56d

Signed-off-by: lhy1024 <admin@liudos.us>

lhy1024 force-pushed the sche-redirect11 branch from b96934b to 8a6f56d Compare November 22, 2023 18:10

rleungx approved these changes Nov 23, 2023

View reviewed changes

ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 23, 2023

CabinfeverB approved these changes Nov 23, 2023

View reviewed changes

ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 23, 2023

ti-chi-bot bot added status/can-merge Indicates a PR has been approved by a committer. and removed status/can-merge Indicates a PR has been approved by a committer. labels Nov 23, 2023

lhy1024 force-pushed the sche-redirect11 branch from 5a2cde9 to 0abe06d Compare November 23, 2023 14:08

make test stable

b777d28

Signed-off-by: lhy1024 <admin@liudos.us>

lhy1024 force-pushed the sche-redirect11 branch from 0abe06d to b777d28 Compare November 23, 2023 18:04

ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 23, 2023

Merge branch 'master' into sche-redirect11

f1115f6

ti-chi-bot bot merged commit c1e4a2a into tikv:master Nov 23, 2023
22 checks passed

lhy1024 deleted the sche-redirect11 branch November 24, 2023 02:39

rleungx mentioned this pull request Nov 30, 2023

Separate scheduling into an independent service #5839

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

mcs: support region http interface in scheduling server #7297

mcs: support region http interface in scheduling server #7297

lhy1024 commented Nov 1, 2023

ti-chi-bot bot commented Nov 1, 2023 •

edited

ti-chi-bot bot commented Nov 1, 2023

rleungx Nov 10, 2023

lhy1024 Nov 10, 2023

rleungx commented Nov 21, 2023

lhy1024 commented Nov 21, 2023

lhy1024 Nov 21, 2023

lhy1024 Nov 22, 2023

lhy1024 Nov 23, 2023

lhy1024 Nov 22, 2023

rleungx Nov 22, 2023

codecov bot commented Nov 22, 2023 •

edited

lhy1024 commented Nov 23, 2023

ti-chi-bot bot commented Nov 23, 2023

ti-chi-bot bot commented Nov 23, 2023

lhy1024 commented Nov 23, 2023

ti-chi-bot bot commented Nov 23, 2023

ti-chi-bot bot commented Nov 23, 2023

ti-chi-bot bot commented Nov 23, 2023

mcs: support region http interface in scheduling server #7297

mcs: support region http interface in scheduling server #7297

Conversation

lhy1024 commented Nov 1, 2023

What problem does this PR solve?

What is changed and how does it work?

Check List

Release note

ti-chi-bot bot commented Nov 1, 2023 • edited

ti-chi-bot bot commented Nov 1, 2023

rleungx Nov 10, 2023

Choose a reason for hiding this comment

lhy1024 Nov 10, 2023

Choose a reason for hiding this comment

rleungx commented Nov 21, 2023

lhy1024 commented Nov 21, 2023

lhy1024 Nov 21, 2023

Choose a reason for hiding this comment

lhy1024 Nov 22, 2023

Choose a reason for hiding this comment

lhy1024 Nov 23, 2023

Choose a reason for hiding this comment

lhy1024 Nov 22, 2023

Choose a reason for hiding this comment

rleungx Nov 22, 2023

Choose a reason for hiding this comment

codecov bot commented Nov 22, 2023 • edited

Codecov Report

lhy1024 commented Nov 23, 2023

ti-chi-bot bot commented Nov 23, 2023

ti-chi-bot bot commented Nov 23, 2023

lhy1024 commented Nov 23, 2023

ti-chi-bot bot commented Nov 23, 2023

ti-chi-bot bot commented Nov 23, 2023

ti-chi-bot bot commented Nov 23, 2023

ti-chi-bot bot commented Nov 1, 2023 •

edited

codecov bot commented Nov 22, 2023 •

edited