Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coordinator: use a healthy region count to start coordinator (#7044) #7363

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #7044

What problem does this PR solve?

Issue Number: Close #6988 ,Close #7016

What is changed and how does it work?

  • different source of region, regard FromSync and FromStorage as the stale region
  • add a stale region count in regionTree to start coordinator first.
  • atomic add/sub stale regions number by region updated

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Release note

use a healthy region count to avoid starting coordinator timeout.

@ti-chi-bot ti-chi-bot added release-note The PR should write the release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-6.5 labels Nov 14, 2023
Copy link
Contributor

ti-chi-bot bot commented Nov 14, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • disksing
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 14, 2023
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 14, 2023
@HuSharp HuSharp force-pushed the cherry-pick-7044-to-release-6.5 branch from b9c8941 to 8034672 Compare November 20, 2023 02:17
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 20, 2023
Signed-off-by: husharp <jinhao.hu@pingcap.com>
@HuSharp HuSharp force-pushed the cherry-pick-7044-to-release-6.5 branch from 8034672 to 872beec Compare November 20, 2023 02:18
Copy link

codecov bot commented Nov 20, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (5a95241) 75.62% compared to head (15d9a75) 75.51%.
Report is 1 commits behind head on release-6.5.

Files Patch % Lines
server/cluster/cluster.go 0.00% 0 Missing and 1 partial ⚠️
server/region_syncer/client.go 66.66% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           release-6.5    #7363      +/-   ##
===============================================
- Coverage        75.62%   75.51%   -0.12%     
===============================================
  Files              332      332              
  Lines            33721    33743      +22     
===============================================
- Hits             25502    25480      -22     
- Misses            6032     6062      +30     
- Partials          2187     2201      +14     
Flag Coverage Δ
unittests 75.51% <94.44%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Nov 20, 2023
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 22, 2023
@bufferflies
Copy link
Contributor

/merge

Copy link
Contributor

ti-chi-bot bot commented Nov 23, 2023

@bufferflies: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Nov 23, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 39070c4

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 23, 2023
@bufferflies
Copy link
Contributor

/merge

Copy link
Contributor

ti-chi-bot bot commented Nov 23, 2023

@bufferflies: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@bufferflies
Copy link
Contributor

/merge

Copy link
Contributor

ti-chi-bot bot commented Nov 24, 2023

@bufferflies: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@bufferflies
Copy link
Contributor

/rebuild

@HuSharp
Copy link
Member

HuSharp commented Nov 24, 2023

/retest

@ti-chi-bot ti-chi-bot bot merged commit d016fed into tikv:release-6.5 Nov 24, 2023
19 checks passed
@HuSharp HuSharp deleted the cherry-pick-7044-to-release-6.5 branch November 24, 2023 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note The PR should write the release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-6.5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants