client/http: encapsulate rule-related PD HTTP interfaces #7397
Conversation
Signed-off-by: JmPotato <ghzpotato@gmail.com>
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
bot
added
release-note-none
size/XL
JmPotato
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #7397 +/- ##
==========================================
- Coverage 74.26% 74.18% -0.09%
==========================================
Files 451 451
Lines 49119 49157 +38
==========================================
- Hits 36480 36466 -14
- Misses 9424 9457 +33
- Partials 3215 3234 +19
Flags with carried forward coverage won't be shown. Click here to find out more. |
| @@ -51,11 +52,24 @@ type Client interface { | |||
| GetHotWriteRegions(context.Context) (*StoreHotPeersInfos, error) | |||
| GetRegionStatusByKeyRange(context.Context, []byte, []byte) (*RegionStats, error) | |||
| GetStores(context.Context) (*StoresInfo, error) | |||
| /* Rule-related interfaces */ | |||
There was a problem hiding this comment.
We have two groups of API for the placement rule, maybe we can reduce it later.
There was a problem hiding this comment.
Yes, after replacing the existing TiDB code, we can reduce the exposed interfaces here.
Signed-off-by: JmPotato <ghzpotato@gmail.com>
JmPotato
force-pushed
the
update_pd_http_client_api
branch
from
fe929aa
to
cd5397a
Compare
ti-chi-bot
bot
added
status/LGT2
|
/merge |
|
@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
This pull request has been accepted and is ready to merge. Commit hash: cd5397a
|
ti-chi-bot
bot
added
the
status/can-merge
|
@JmPotato: Your PR was out of date, I have automatically updated it for you. If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
Issue Number: ref #7300.
What is changed and how does it work?
Check List
Tests
Release note