Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: fix to make GetMinTS enable forward #7482

Merged
merged 3 commits into from
Nov 30, 2023
Merged

Conversation

CabinfeverB
Copy link
Member

What problem does this PR solve?

Issue Number: Close #7467

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

Release note

None.

Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>
Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>
Copy link
Contributor

ti-chi-bot bot commented Nov 30, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • nolouch
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added needs-cherry-pick-release-7.1 release-note-none needs-cherry-pick-release-7.5 size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 30, 2023
Copy link

codecov bot commented Nov 30, 2023

Codecov Report

Merging #7482 (124a40f) into master (beedacb) will increase coverage by 0.12%.
Report is 2 commits behind head on master.
The diff coverage is 60.00%.

❗ Current head 124a40f differs from pull request most recent head f2c3ea5. Consider uploading reports for the commit f2c3ea5 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7482      +/-   ##
==========================================
+ Coverage   74.31%   74.44%   +0.12%     
==========================================
  Files         451      451              
  Lines       49757    49724      -33     
==========================================
+ Hits        36977    37016      +39     
+ Misses       9456     9399      -57     
+ Partials     3324     3309      -15     
Flag Coverage Δ
unittests 74.44% <60.00%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@rleungx rleungx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but do we need to cherry pick?

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 30, 2023
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 30, 2023
@CabinfeverB
Copy link
Member Author

LGTM, but do we need to cherry pick?

There's no need.

@CabinfeverB
Copy link
Member Author

/merge

Copy link
Contributor

ti-chi-bot bot commented Nov 30, 2023

@CabinfeverB: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Nov 30, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 124a40f

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 30, 2023
Copy link
Contributor

ti-chi-bot bot commented Nov 30, 2023

@CabinfeverB: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit d91886f into tikv:master Nov 30, 2023
22 checks passed
@CabinfeverB CabinfeverB changed the title *: support forward GetMinTS *: fix to make GetMinTS enable forward Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In GetMinTS, the forward logic of the client and server do not match
3 participants