Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schedulers: fix config data race #7486

Merged
merged 4 commits into from
Nov 30, 2023
Merged

Conversation

lhy1024
Copy link
Contributor

@lhy1024 lhy1024 commented Nov 30, 2023

What problem does this PR solve?

Issue Number: Close #7485

What is changed and how does it work?

Check List

Tests

  • Unit test

Release note

None.

Signed-off-by: lhy1024 <admin@liudos.us>
Copy link
Contributor

ti-chi-bot bot commented Nov 30, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JmPotato
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 30, 2023
Signed-off-by: lhy1024 <admin@liudos.us>
Signed-off-by: lhy1024 <admin@liudos.us>
Copy link

codecov bot commented Nov 30, 2023

Codecov Report

Merging #7486 (4ea9bb5) into master (150139c) will decrease coverage by 0.04%.
The diff coverage is 72.41%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7486      +/-   ##
==========================================
- Coverage   74.34%   74.30%   -0.04%     
==========================================
  Files         451      451              
  Lines       49726    49757      +31     
==========================================
+ Hits        36969    36973       +4     
- Misses       9433     9459      +26     
- Partials     3324     3325       +1     
Flag Coverage Δ
unittests 74.30% <72.41%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 30, 2023
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 30, 2023
@lhy1024
Copy link
Contributor Author

lhy1024 commented Nov 30, 2023

/merge

Copy link
Contributor

ti-chi-bot bot commented Nov 30, 2023

@lhy1024: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Nov 30, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 4ea9bb5

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 30, 2023
@ti-chi-bot ti-chi-bot bot merged commit beedacb into tikv:master Nov 30, 2023
25 of 26 checks passed
@rleungx rleungx added component/mcs Microservice. and removed component/mcs Microservice. labels Nov 30, 2023
rleungx pushed a commit to rleungx/pd that referenced this pull request Dec 1, 2023
close tikv#7485

Signed-off-by: lhy1024 <admin@liudos.us>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Datarace in scheduler config
3 participants