New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: fix all errors detected by testifylint and enable it #7589
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
1d0b63a
to
5205772
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #7589 +/- ##
==========================================
+ Coverage 74.69% 74.80% +0.10%
==========================================
Files 457 457
Lines 50397 50397
==========================================
+ Hits 37646 37698 +52
+ Misses 9410 9364 -46
+ Partials 3341 3335 -6
Flags with carried forward coverage won't be shown. Click here to find out more. |
func (suite *mergeCheckerTestSuite) TestStoreLimitWithMerge() { | ||
re := suite.Require() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why replace suite with re?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using suite.Require()
will call t.FailNow()
to fatal the test as soon as possible rather than calling t.Fail()
.
Signed-off-by: JmPotato <ghzpotato@gmail.com>
Signed-off-by: JmPotato <ghzpotato@gmail.com>
4d0dc9c
to
4c87e3b
Compare
/merge |
@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 4c87e3b
|
@JmPotato: Your PR was out of date, I have automatically updated it for you. If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
Issue Number: ref #4813.
What is changed and how does it work?
Check List
Tests
Release note