Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: fix all errors detected by testifylint and enable it #7589

Merged
merged 3 commits into from Dec 21, 2023

Conversation

JmPotato
Copy link
Member

What problem does this PR solve?

Issue Number: ref #4813.

What is changed and how does it work?

Fix all errors detected by testifylint and enable it.

Check List

Tests

  • Unit test
  • Integration test

Release note

None.

Copy link
Contributor

ti-chi-bot bot commented Dec 20, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • HuSharp
  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Dec 20, 2023
@ti-chi-bot ti-chi-bot bot requested a review from lhy1024 December 20, 2023 05:43
@JmPotato JmPotato force-pushed the use_testifylint branch 2 times, most recently from 1d0b63a to 5205772 Compare December 20, 2023 06:06
Copy link

codecov bot commented Dec 20, 2023

Codecov Report

Merging #7589 (5df0b49) into master (66508f5) will increase coverage by 0.10%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7589      +/-   ##
==========================================
+ Coverage   74.69%   74.80%   +0.10%     
==========================================
  Files         457      457              
  Lines       50397    50397              
==========================================
+ Hits        37646    37698      +52     
+ Misses       9410     9364      -46     
+ Partials     3341     3335       -6     
Flag Coverage Δ
unittests 74.80% <ø> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Comment on lines 445 to +446
func (suite *mergeCheckerTestSuite) TestStoreLimitWithMerge() {
re := suite.Require()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why replace suite with re?

Copy link
Member Author

@JmPotato JmPotato Dec 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using suite.Require() will call t.FailNow() to fatal the test as soon as possible rather than calling t.Fail().

Signed-off-by: JmPotato <ghzpotato@gmail.com>
Signed-off-by: JmPotato <ghzpotato@gmail.com>
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 21, 2023
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 21, 2023
@JmPotato
Copy link
Member Author

/merge

Copy link
Contributor

ti-chi-bot bot commented Dec 21, 2023

@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Dec 21, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 4c87e3b

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 21, 2023
Copy link
Contributor

ti-chi-bot bot commented Dec 21, 2023

@JmPotato: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit 7f156d9 into tikv:master Dec 21, 2023
26 checks passed
@JmPotato JmPotato deleted the use_testifylint branch December 21, 2023 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/testing CI testing. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants