Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client/http: add more interface for BR/lightning #7602

Merged
merged 5 commits into from Dec 21, 2023

Conversation

lance6716
Copy link
Contributor

What problem does this PR solve?

Issue Number: ref #7300

What is changed and how does it work?

Check List

Tests

  • Unit test

Code changes

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

Release note

None.

Signed-off-by: lance6716 <lance6716@gmail.com>
Copy link
Contributor

ti-chi-bot bot commented Dec 21, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JmPotato
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot requested review from JmPotato and Yisaer December 21, 2023 04:51
@ti-chi-bot ti-chi-bot bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 21, 2023
@lance6716
Copy link
Contributor Author

/auto-cc

@ti-chi-bot ti-chi-bot bot requested review from nolouch and rleungx December 21, 2023 04:51
Copy link

codecov bot commented Dec 21, 2023

Codecov Report

Merging #7602 (3bbded5) into master (d4ebef8) will decrease coverage by 0.02%.
The diff coverage is 88.88%.

❗ Current head 3bbded5 differs from pull request most recent head 60150ec. Consider uploading reports for the commit 60150ec to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7602      +/-   ##
==========================================
- Coverage   74.84%   74.82%   -0.02%     
==========================================
  Files         457      457              
  Lines       50397    50415      +18     
==========================================
+ Hits        37718    37724       +6     
- Misses       9353     9360       +7     
- Partials     3326     3331       +5     
Flag Coverage Δ
unittests 74.82% <88.88%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: lance6716 <lance6716@gmail.com>
Signed-off-by: lance6716 <lance6716@gmail.com>
got, err := suite.client.GetPlacementRule(suite.ctx, rule.GroupID, rule.ID)
re.NoError(err)
// skip comparison of the generated field StartKeyHex
got.StartKeyHex = rule.StartKeyHex
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about the end key?

Signed-off-by: lance6716 <lance6716@gmail.com>
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 21, 2023
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 21, 2023
@JmPotato
Copy link
Member

/merge

Copy link
Contributor

ti-chi-bot bot commented Dec 21, 2023

@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Dec 21, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 3bbded5

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 21, 2023
Copy link
Contributor

ti-chi-bot bot commented Dec 21, 2023

@lance6716: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit f15db4b into tikv:master Dec 21, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants