Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http/client, retry: copy a new Backoffer for each request #7684

Merged
merged 1 commit into from
Jan 9, 2024
Merged

http/client, retry: copy a new Backoffer for each request #7684

merged 1 commit into from
Jan 9, 2024

Conversation

JmPotato
Copy link
Member

@JmPotato JmPotato commented Jan 9, 2024

What problem does this PR solve?

Issue Number: ref #7300, #7673.

What is changed and how does it work?

Copy a new `Backoffer` for each request to prevent race.

Check List

Tests

  • Unit test
  • Integration test

Release note

None.

@JmPotato JmPotato added the component/client Client logic. label Jan 9, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jan 9, 2024 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • HuSharp
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added release-note-none size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 9, 2024
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 9, 2024
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 9, 2024
@HuSharp
Copy link
Member

HuSharp commented Jan 9, 2024

It would be good to add a race test

@JmPotato
Copy link
Member Author

JmPotato commented Jan 9, 2024

/merge

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jan 9, 2024

@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jan 9, 2024

This pull request has been accepted and is ready to merge.

Commit hash: fe5b3f3

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 9, 2024
@JmPotato
Copy new Backoffer for each request
3b3b3e0 
Signed-off-by: JmPotato <ghzpotato@gmail.com>
@ti-chi-bot ti-chi-bot bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed status/can-merge Indicates a PR has been approved by a committer. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 9, 2024
@JmPotato
Copy link
Member Author

JmPotato commented Jan 9, 2024

/merge

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jan 9, 2024

@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jan 9, 2024

This pull request has been accepted and is ready to merge.

Commit hash: 3b3b3e0

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 9, 2024
@ti-chi-bot ti-chi-bot bot merged commit dd8df25 into tikv:master Jan 9, 2024
22 checks passed
@JmPotato JmPotato deleted the fix-backoffer-race branch January 9, 2024 10:00
pingandb pushed a commit to pingandb/pd that referenced this pull request Jan 18, 2024
@JmPotato @pingandb
http/client, retry: copy a new Backoffer for each request (tikv#7684)
503a22c 
ref tikv#7300

Copy a new `Backoffer` for each request to prevent race.

Signed-off-by: JmPotato <ghzpotato@gmail.com>
Signed-off-by: pingandb <songge102@pingan.com.cn>
JmPotato added a commit to JmPotato/pd that referenced this pull request Jan 25, 2024
@JmPotato
http/client, retry: copy a new Backoffer for each request (tikv#7684)
1da8d9d 
ref tikv#7300

Copy a new `Backoffer` for each request to prevent race.

Signed-off-by: JmPotato <ghzpotato@gmail.com>
@HuSharp HuSharp mentioned this pull request Jan 29, 2024
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rleungx rleungx rleungx approved these changes

@HuSharp HuSharp HuSharp approved these changes

Assignees
No one assigned
Labels
component/client Client logic. release-note-none size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JmPotato @HuSharp @rleungx