http: add Admin API and Config with TTL API #7699
Conversation
Signed-off-by: lance6716 <lance6716@gmail.com>
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
bot
added
the
size/L
| newConfig = map[string]interface{}{ | ||
| "schedule.leader-schedule-limit": float64(16), | ||
| } | ||
| err = suite.client.SetConfig(suite.ctx, newConfig, 1) |
There was a problem hiding this comment.
Better validate whether the TTL takes effect.
There was a problem hiding this comment.
unit test shows GetConfig will not see TTL config, can you help me verify if it's expected?
There was a problem hiding this comment.
After checking the code, it seems the only way to read the TTL config from outside is to access etcd directly.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #7699 +/- ##
=======================================
Coverage 73.73% 73.73%
=======================================
Files 429 429
Lines 47413 47469 +56
=======================================
+ Hits 34959 35003 +44
- Misses 9468 9476 +8
- Partials 2986 2990 +4
Flags with carried forward coverage won't be shown. Click here to find out more. |
| @@ -27,6 +27,7 @@ import ( | |||
| pd "github.com/tikv/pd/client/http" | |||
| "github.com/tikv/pd/client/retry" | |||
| "github.com/tikv/pd/pkg/core" | |||
| config2 "github.com/tikv/pd/pkg/schedule/config" | |||
There was a problem hiding this comment.
It seems that other codes use this name
| config2 "github.com/tikv/pd/pkg/schedule/config" | |
| sc "github.com/tikv/pd/pkg/schedule/config" |
Signed-off-by: lance6716 <lance6716@gmail.com>
|
ping @JmPotato |
ti-chi-bot
bot
added
status/LGT2
|
I don't have access to merge, please help me merge it |
|
/merge |
|
@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
This pull request has been accepted and is ready to merge. Commit hash: a93b7d2
|
ti-chi-bot
bot
added
the
status/can-merge
ref tikv#7300 Signed-off-by: lance6716 <lance6716@gmail.com> Signed-off-by: pingandb <songge102@pingan.com.cn>
What problem does this PR solve?
Issue Number: ref #7300
What is changed and how does it work?
Check List
Tests
Code changes
Side effects
Related changes
pingcap/docs/pingcap/docs-cn:pingcap/tiup:Release note