Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: fix store statistics #7771

Merged
merged 1 commit into from Jan 29, 2024
Merged

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Jan 29, 2024

What problem does this PR solve?

Issue Number: Ref #7703.

What is changed and how does it work?

Check List

Tests

  • Manual test

Release note

None.

Signed-off-by: Ryan Leung <rleungx@gmail.com>
Copy link
Contributor

ti-chi-bot bot commented Jan 29, 2024

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CabinfeverB

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot requested review from HunDunDM and lhy1024 January 29, 2024 02:48
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 29, 2024
@rleungx rleungx requested review from CabinfeverB and removed request for HunDunDM January 29, 2024 02:49
Copy link

codecov bot commented Jan 29, 2024

Codecov Report

Merging #7771 (6902b56) into master (5b939c6) will decrease coverage by 0.04%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7771      +/-   ##
==========================================
- Coverage   69.85%   69.82%   -0.04%     
==========================================
  Files         430      430              
  Lines       47632    47632              
==========================================
- Hits        33274    33259      -15     
- Misses      11615    11618       +3     
- Partials     2743     2755      +12     
Flag Coverage Δ
unittests 69.82% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 29, 2024
@rleungx rleungx added the require-LGT1 Indicates that the PR requires an LGTM. label Jan 29, 2024
@rleungx
Copy link
Member Author

rleungx commented Jan 29, 2024

/merge

Copy link
Contributor

ti-chi-bot bot commented Jan 29, 2024

@rleungx: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Jan 29, 2024

This pull request has been accepted and is ready to merge.

Commit hash: 6902b56

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 29, 2024
@ti-chi-bot ti-chi-bot bot merged commit 7142cf4 into tikv:master Jan 29, 2024
25 of 27 checks passed
@rleungx rleungx deleted the fix-store-statistics branch January 29, 2024 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none require-LGT1 Indicates that the PR requires an LGTM. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants