Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client: return total wait duration in resource interceptor OnRequestWait call (#7488) #7794

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #7488

What problem does this PR solve?

Issue Number: ref #5851

What is changed and how does it work?

return total wait duration in resource interceptor OnRequestWait call so we can track the wait duration in tidb slow log.

Check List

Tests

  • Unit test

Code changes

Side effects

Related changes

Release note

None.

ref tikv#5851

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Copy link
Contributor

ti-chi-bot bot commented Feb 2, 2024

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CabinfeverB
  • HuSharp

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

Signed-off-by: glorv <glorvs@163.com>
@glorv glorv force-pushed the cherry-pick-7488-to-release-7.5 branch from 1e9b04d to c36afc2 Compare February 2, 2024 07:28
Copy link

codecov bot commented Feb 2, 2024

Codecov Report

Merging #7794 (c36afc2) into release-7.5 (a276843) will decrease coverage by 0.03%.
Report is 3 commits behind head on release-7.5.
The diff coverage is 46.51%.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-7.5    #7794      +/-   ##
===============================================
- Coverage        74.62%   74.60%   -0.03%     
===============================================
  Files              443      443              
  Lines            47923    47952      +29     
===============================================
+ Hits             35764    35775      +11     
- Misses            8996     9014      +18     
  Partials          3163     3163              
Flag Coverage Δ
unittests 74.60% <46.51%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@HuSharp HuSharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 2, 2024
@HuSharp HuSharp requested review from CabinfeverB and removed request for disksing February 2, 2024 07:57
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 2, 2024
@CabinfeverB
Copy link
Member

/merge

Copy link
Contributor

ti-chi-bot bot commented Feb 2, 2024

@CabinfeverB: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Feb 2, 2024

This pull request has been accepted and is ready to merge.

Commit hash: c36afc2

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 2, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Feb 2, 2024
@ti-chi-bot ti-chi-bot bot merged commit 6978558 into tikv:release-7.5 Feb 2, 2024
22 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note-none size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-7.5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants