Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: fix typos #7866

Merged
merged 2 commits into from Mar 1, 2024
Merged

*: fix typos #7866

merged 2 commits into from Mar 1, 2024

Conversation

HuSharp
Copy link
Member

@HuSharp HuSharp commented Mar 1, 2024

What problem does this PR solve?

Issue Number: Ref #4399

What is changed and how does it work?

inspired by fix typo trend in https://github.com/cloudflare/pingora/pulls 馃お
using https://github.com/crate-ci/typos

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Release note

None.

Copy link
Contributor

ti-chi-bot bot commented Mar 1, 2024

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CabinfeverB
  • JmPotato

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added release-note-none size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 1, 2024
Copy link

codecov bot commented Mar 1, 2024

Codecov Report

Merging #7866 (9fe18f1) into master (6cb8917) will increase coverage by 0.02%.
The diff coverage is 90.47%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7866      +/-   ##
==========================================
+ Coverage   73.45%   73.47%   +0.02%     
==========================================
  Files         432      432              
  Lines       47967    47967              
==========================================
+ Hits        35232    35244      +12     
+ Misses       9686     9677       -9     
+ Partials     3049     3046       -3     
Flag Coverage 螖
unittests 73.47% <90.47%> (+0.02%) 猬嗭笍

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: husharp <jinhao.hu@pingcap.com>
pkg/schedule/labeler/labeler_test.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 1, 2024
Signed-off-by: husharp <jinhao.hu@pingcap.com>
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 1, 2024
@JmPotato
Copy link
Member

JmPotato commented Mar 1, 2024

/merge

Copy link
Contributor

ti-chi-bot bot commented Mar 1, 2024

@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Mar 1, 2024

This pull request has been accepted and is ready to merge.

Commit hash: 9fe18f1

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 1, 2024
@ti-chi-bot ti-chi-bot bot merged commit 5f5fdb2 into tikv:master Mar 1, 2024
25 of 26 checks passed
@HuSharp HuSharp deleted the fix_typo_by_typos branch March 1, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants