Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pd-ctl: hidden some hot scheduler config #7892

Merged
merged 6 commits into from Apr 12, 2024
Merged

Conversation

lhy1024
Copy link
Contributor

@lhy1024 lhy1024 commented Mar 7, 2024

What problem does this PR solve?

Issue Number: ref #5691

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Manual test (add detailed scripts or steps below)
    image

Related changes

Release note

None.

Signed-off-by: lhy1024 <admin@liudos.us>
Copy link
Contributor

ti-chi-bot bot commented Mar 7, 2024

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • HuSharp
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot requested review from nolouch and rleungx March 7, 2024 05:58
@ti-chi-bot ti-chi-bot bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 7, 2024
Copy link

codecov bot commented Mar 7, 2024

Codecov Report

Merging #7892 (c551ba7) into master (1cd99f1) will decrease coverage by 3.72%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

❗ Current head c551ba7 differs from pull request most recent head e5264c2. Consider uploading reports for the commit e5264c2 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7892      +/-   ##
==========================================
- Coverage   77.25%   73.53%   -3.72%     
==========================================
  Files         468      436      -32     
  Lines       60937    48374   -12563     
==========================================
- Hits        47078    35573   -11505     
+ Misses      10302     9744     -558     
+ Partials     3557     3057     -500     
Flag Coverage Δ
unittests 73.53% <ø> (-3.72%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@HuSharp
Copy link
Member

HuSharp commented Mar 20, 2024

please fix static :)

Signed-off-by: lhy1024 <admin@liudos.us>
Signed-off-by: lhy1024 <admin@liudos.us>
Signed-off-by: lhy1024 <admin@liudos.us>
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 22, 2024
@easonn7
Copy link

easonn7 commented Apr 12, 2024

/approve

@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 12, 2024
@lhy1024
Copy link
Contributor Author

lhy1024 commented Apr 12, 2024

/merge

Copy link
Contributor

ti-chi-bot bot commented Apr 12, 2024

@lhy1024: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Apr 12, 2024

This pull request has been accepted and is ready to merge.

Commit hash: c551ba7

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 12, 2024
@ti-chi-bot ti-chi-bot bot merged commit 5da6def into tikv:master Apr 12, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants