New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
client: add status http interface #7903
Conversation
Signed-off-by: Ryan Leung <rleungx@gmail.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
client/http/types.go
Outdated
@@ -34,6 +34,15 @@ type ClusterState struct { | |||
ReplicationStatus string `json:"replication_status"` | |||
} | |||
|
|||
// State is the status of PD server. | |||
// NOTE: This type is exported by HTTP API. Please pay more attention when modifying it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it would be better to associate to the original type place?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #7903 +/- ##
==========================================
+ Coverage 73.41% 73.44% +0.03%
==========================================
Files 434 434
Lines 48079 48088 +9
==========================================
+ Hits 35298 35320 +22
+ Misses 9735 9723 -12
+ Partials 3046 3045 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: Ryan Leung <rleungx@gmail.com>
/merge |
@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 3fa4639
|
What problem does this PR solve?
Issue Number: Ref #7300.
What is changed and how does it work?
Add status API which TiDB uses it.
Check List
Tests
Release note