Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client: add status http interface #7903

Merged
merged 3 commits into from Mar 12, 2024

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Mar 11, 2024

What problem does this PR solve?

Issue Number: Ref #7300.

What is changed and how does it work?

Add status API which TiDB uses it.

Check List

Tests

  • Unit test

Release note

None.

Signed-off-by: Ryan Leung <rleungx@gmail.com>
Copy link
Contributor

ti-chi-bot bot commented Mar 11, 2024

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • HuSharp
  • JmPotato

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot requested review from JmPotato and Yisaer March 11, 2024 09:44
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/needs-linked-issue labels Mar 11, 2024
@rleungx rleungx requested review from HuSharp and removed request for Yisaer March 11, 2024 09:45
@@ -34,6 +34,15 @@ type ClusterState struct {
ReplicationStatus string `json:"replication_status"`
}

// State is the status of PD server.
// NOTE: This type is exported by HTTP API. Please pay more attention when modifying it.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it would be better to associate to the original type place?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link

codecov bot commented Mar 11, 2024

Codecov Report

Merging #7903 (3fa4639) into master (1d77b25) will increase coverage by 0.03%.
Report is 1 commits behind head on master.
The diff coverage is 77.77%.

❗ Current head 3fa4639 differs from pull request most recent head 418a5ff. Consider uploading reports for the commit 418a5ff to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7903      +/-   ##
==========================================
+ Coverage   73.41%   73.44%   +0.03%     
==========================================
  Files         434      434              
  Lines       48079    48088       +9     
==========================================
+ Hits        35298    35320      +22     
+ Misses       9735     9723      -12     
+ Partials     3046     3045       -1     
Flag Coverage Δ
unittests 73.44% <77.77%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: Ryan Leung <rleungx@gmail.com>
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 11, 2024
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 12, 2024
@JmPotato
Copy link
Member

/merge

Copy link
Contributor

ti-chi-bot bot commented Mar 12, 2024

@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Mar 12, 2024

This pull request has been accepted and is ready to merge.

Commit hash: 3fa4639

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 12, 2024
@ti-chi-bot ti-chi-bot bot merged commit efffcc5 into tikv:master Mar 12, 2024
22 checks passed
@rleungx rleungx deleted the add-more-http-interface branch March 12, 2024 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants