Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dashboard): update TiDB Dashboard to v8.0.0-9768844f [master] #7985

Conversation

baurine
Copy link
Contributor

@baurine baurine commented Mar 26, 2024

What problem does this PR solve?

Issue Number: Close #7989 ref #4257

Update TiDB Dashboard to v8.0.0-9768844f.

This PR fixes the error that hosts/disks/statistics page can't show normally when use pd micro-service mode.

TiDB Dashboard side PR: pingcap/tidb-dashboard#1664

image

Release note

None

Test

$ make pd-server
$ cp bin/pd-server ~/.tiup/components/pd/v8.0.0-alpha-nightly/pd-server
# pd ms mode
$ tiup playground nightly --pd.mode ms --pd.api 1 --pd.scheduling 1 --pd.tso 1 --pd.rm 0 --kv 3 --tiflash 0 --db 1
# pd non-ms mode
$ tiup playground nightly --tiflash 0

image

Signed-off-by: baurine <2008.hbl@gmail.com>
Copy link
Contributor

ti-chi-bot bot commented Mar 26, 2024

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • HuSharp
  • lhy1024

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

Copy link
Contributor

ti-chi-bot bot commented Mar 26, 2024

Hi @baurine. Thanks for your PR.

I'm waiting for a tikv member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot requested review from JmPotato and rleungx March 26, 2024 11:27
@ti-chi-bot ti-chi-bot bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 26, 2024
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

Merging #7985 (95e8e6a) into master (423e36c) will decrease coverage by 0.12%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

❗ Current head 95e8e6a differs from pull request most recent head 1abc10c. Consider uploading reports for the commit 1abc10c to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7985      +/-   ##
==========================================
- Coverage   73.68%   73.56%   -0.12%     
==========================================
  Files         436      436              
  Lines       48464    48464              
==========================================
- Hits        35709    35651      -58     
- Misses       9710     9749      +39     
- Partials     3045     3064      +19     
Flag Coverage Δ
unittests 73.56% <ø> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@HuSharp
Copy link
Member

HuSharp commented Mar 27, 2024

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 27, 2024
@HuSharp HuSharp requested a review from lhy1024 March 27, 2024 06:06
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 27, 2024
@HuSharp
Copy link
Member

HuSharp commented Mar 27, 2024

/merge

Copy link
Contributor

ti-chi-bot bot commented Mar 27, 2024

@HuSharp: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Mar 27, 2024

This pull request has been accepted and is ready to merge.

Commit hash: 95e8e6a

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 27, 2024
Copy link
Contributor

ti-chi-bot bot commented Mar 27, 2024

@baurine: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit 5a24dc0 into tikv:master Mar 27, 2024
22 checks passed
@baurine baurine deleted the update-tidb-dashboard/master-v8.0.0-9768844f-1711452411 branch March 27, 2024 06:36
@HuSharp HuSharp added the needs-cherry-pick-release-8.0 The PR needs to cherry pick to release-8.0 branch. label Mar 27, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.0: #7990.

ti-chi-bot bot pushed a commit that referenced this pull request Mar 27, 2024
…7985) (#7990)

ref #4257, close #7989

Signed-off-by: baurine <2008.hbl@gmail.com>

Co-authored-by: baurine <2008.hbl@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-8.0 The PR needs to cherry pick to release-8.0 branch. ok-to-test release-note-none size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tidb-dashboard show errors in the cluster info hosts/disks/statistics page
4 participants