*: fix ci covprofile by updating codecov version and replacing cover pkg #8044
Conversation
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
|
Skipping CI for Draft Pull Request. |
ti-chi-bot
bot
added
release-note-none
do-not-merge/work-in-progress
ti-chi-bot
bot
added
the
size/S
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #8044 +/- ##
===========================================
+ Coverage 65.31% 77.30% +11.98%
===========================================
Files 465 468 +3
Lines 52480 60867 +8387
===========================================
+ Hits 34279 47053 +12774
+ Misses 15183 10273 -4910
- Partials 3018 3541 +523
Flags with carried forward coverage won't be shown. Click here to find out more. |
HuSharp
force-pushed
the
fix_coverprofile
branch
from
ec346ec
to
7f558dc
Compare
ti-chi-bot
bot
removed
the
do-not-merge/work-in-progress
| @@ -72,7 +72,7 @@ jobs: | |||
| TOTAL_JOBS: ${{needs.chunks.outputs.job-total}} | |||
| run: for i in $(seq 1 $TOTAL_JOBS); do cat covprofile_$i >> covprofile; done | |||
| - name: Send coverage | |||
| uses: codecov/codecov-action@v1 | |||
| uses: codecov/codecov-action@v4.2.0 | |||
There was a problem hiding this comment.
error is
https://codecov.io/upload/v4?package=github-action-v1.5.2-1.0.3&token=secret&branch=improve-linter&commit=9f34462e696c925657636f437c894bad31fac16e&build=8586757005&build_url=http%3A%2F%2Fgithub.com%2Ftikv%2Fpd%2Factions%2Fruns%2F8586757005&name=codecov-umbrella&tag=&slug=tikv%2Fpd&service=github-actions&flags=unittests&pr=8015&job=PD+Test&cmd_args=n,F,Q,f,C
{'detail': ErrorDetail(string='Unable to locate build via Github Actions API. Please upload with the Codecov repository upload token to resolve issue.', code='not_found')}need to update codecov version ref codecov/codecov-action#557
can check more information in https://github.com/tikv/pd/actions/runs/8586757005/job/23529728059?pr=8015
|
| @@ -35,8 +35,8 @@ test: failpoint-enable | |||
| $(MAKE) failpoint-disable | |||
|
|
|||
| ci-test-job: | |||
| if [ -f covprofile ]; then rm ./$(value test_name)/covprofile; fi | |||
| CGO_ENABLED=1 go test ./$(value test_name)/... -v -tags deadlock -race -cover -covermode=atomic -coverprofile=./$(value test_name)/covprofile -coverpkg=$(ROOT_PATH)/... | |||
| if [ -f ./$(value test_name)/covprofile ]; then rm ./$(value test_name)/covprofile; fi | |||
There was a problem hiding this comment.
use absolute path because
meet such error no packages being tested depend on matches for pattern /data/nvme0n1/husharp/proj/pd/client/../...
HuSharp
changed the title
HuSharp
changed the title
|
/merge |
|
@nolouch: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
This pull request has been accepted and is ready to merge. Commit hash: 7f558dc
|
ti-chi-bot
bot
added
the
status/can-merge
|
@HuSharp: Your PR was out of date, I have automatically updated it for you. If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
Issue Number: Ref #4399
What is changed and how does it work?
meet error
no packages being tested depend on matches for pattern /data/nvme0n1/husharp/proj/pd/client/../...Check List
Tests
Release note