client/tso: organize the methods of TSO dispatcher #8121
Conversation
Signed-off-by: JmPotato <ghzpotato@gmail.com>
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
bot
added
release-note-none
size/XXL
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #8121 +/- ##
==========================================
- Coverage 77.38% 77.27% -0.11%
==========================================
Files 471 470 -1
Lines 61240 61145 -95
==========================================
- Hits 47389 47249 -140
- Misses 10280 10328 +48
+ Partials 3571 3568 -3
Flags with carried forward coverage won't be shown. Click here to find out more. |
| @@ -115,6 +86,17 @@ func (c *tsoClient) dispatchRequest(request *tsoRequest) (bool, error) { | |||
| return false, nil | |||
| } | |||
|
|
|||
| func (c *tsoClient) closeTSODispatcher() { | |||
There was a problem hiding this comment.
Shall we move the tsoClient-related function to tso_client.go?
There was a problem hiding this comment.
Currently, because all data structures are inside tsoClient, it is impossible to strictly distinguish them according to files. The organization logic here is to put as much dispatcher-related code as possible in tso_dispatcher.go, and then move some common methods to tso_client.go. Perhaps we can further abstract the data structure in the future and put all dispatcher-related logic into a separate structure.
|
/merge |
|
@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
This pull request has been accepted and is ready to merge. Commit hash: 32a7a7a
|
ti-chi-bot
bot
added
the
status/can-merge
|
@JmPotato: Your PR was out of date, I have automatically updated it for you. If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
ref tikv#8047 Organize the methods of the TSO dispatcher. Signed-off-by: JmPotato <ghzpotato@gmail.com> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
What problem does this PR solve?
Issue Number: ref #8047.
What is changed and how does it work?
Check List
Tests
Release note