*: individually check the scheduling halt for online unsafe recovery #8147

JmPotato · 2024-05-07T06:11:41Z

What problem does this PR solve?

Issue Number: close #8095, ref #6493.

What is changed and how does it work?

Individually check the scheduling halt for online unsafe recovery to avoid unexpectedly persisting the halt option in the intermediate process.

Check List

Tests

Unit test
Integration test

Release note

Fix the issue where the cluster cannot recover normally after using the online unsafe recovery.

Signed-off-by: JmPotato <ghzpotato@gmail.com>

ti-chi-bot · 2024-05-07T06:11:44Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

HuSharp
rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

codecov · 2024-05-07T06:24:39Z

Codecov Report

Attention: Patch coverage is 45.45455% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 77.38%. Comparing base (44d57b6) to head (4d44354).

❗ Current head 4d44354 differs from pull request most recent head 9a4d9c8. Consider uploading reports for the commit 9a4d9c8 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #8147      +/-   ##
==========================================
- Coverage   77.44%   77.38%   -0.07%     
==========================================
  Files         471      471              
  Lines       61348    61347       -1     
==========================================
- Hits        47510    47472      -38     
- Misses      10278    10310      +32     
- Partials     3560     3565       +5

Flag	Coverage Δ
unittests	`77.38% <45.45%> (-0.07%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

rleungx · 2024-05-07T07:08:25Z

server/config/persist_options.go

@@ -1001,6 +998,14 @@ func (o *PersistOptions) SetHaltScheduling(halt bool, source string) {
 	}
 }

+// SetHaltScheduling set HaltScheduling.
+func (o *PersistOptions) SetHaltScheduling(halt bool, source string) {


What will the source be if we use API to set it?

PTAL https://github.com/tikv/pd/pull/8147/files#diff-78f42ba40d0f10b08c73b7e6bb8376f398e249c963cf549e89591d6b6826b9a4R1064-R1065

Do we still need SetHaltScheduling function if we have SetSchedulingAllowanceStatus?

Currently, it's not used anymore, but I think it's okay to leave it there.

Signed-off-by: JmPotato <ghzpotato@gmail.com>

JmPotato · 2024-05-08T07:47:14Z

/merge

ti-chi-bot · 2024-05-08T07:47:16Z

@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2024-05-08T07:47:18Z

This pull request has been accepted and is ready to merge.

Commit hash: 4d44354

ti-chi-bot · 2024-05-08T10:27:09Z

In response to a cherrypick label: new pull request created to branch release-8.1: #8155.

…8147) (#8155) ref #6493, close #8095 Individually check the scheduling halt for online unsafe recovery to avoid unexpectedly persisting the halt option in the intermediate process. Signed-off-by: JmPotato <ghzpotato@gmail.com> Co-authored-by: JmPotato <ghzpotato@gmail.com>

lhy1024 · 2024-05-20T04:18:24Z

/cherry-pick release-7.1

lhy1024 · 2024-05-20T04:18:28Z

/cherry-pick release-7.5

ti-chi-bot · 2024-05-20T04:19:01Z

@lhy1024: new pull request created to branch release-7.1: #8193.

In response to this:

/cherry-pick release-7.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ref tikv#6493, close tikv#8095 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

ti-chi-bot · 2024-05-20T04:19:04Z

@lhy1024: new pull request created to branch release-7.5: #8194.

In response to this:

/cherry-pick release-7.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ref tikv#6493, close tikv#8095 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

…8147) (#8194) ref #6493, close #8095 Individually check the scheduling halt for online unsafe recovery to avoid unexpectedly persisting the halt option in the intermediate process. Signed-off-by: JmPotato <ghzpotato@gmail.com> Co-authored-by: JmPotato <ghzpotato@gmail.com> Co-authored-by: lhy1024 <liuhanyang@pingcap.com>

Individually check the scheduling halt for online unsafe recovery

d59b69a

Signed-off-by: JmPotato <ghzpotato@gmail.com>

JmPotato added the component/schedule Scheduling logic. label May 7, 2024

JmPotato requested review from lhy1024, rleungx and HuSharp May 7, 2024 06:11

ti-chi-bot bot added release-note The PR should write the release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 7, 2024

rleungx reviewed May 7, 2024

View reviewed changes

Update the scheduling halt status after the API call

4d44354

Signed-off-by: JmPotato <ghzpotato@gmail.com>

JmPotato requested a review from rleungx May 7, 2024 08:18

rleungx approved these changes May 7, 2024

View reviewed changes

ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 7, 2024

HuSharp approved these changes May 8, 2024

View reviewed changes

ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 8, 2024

ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label May 8, 2024

Merge branch 'master' into update_unsafe_recovery_halt

9a4d9c8

ti-chi-bot bot merged commit 740f15e into tikv:master May 8, 2024
22 checks passed

JmPotato deleted the update_unsafe_recovery_halt branch May 8, 2024 08:48

JmPotato added the needs-cherry-pick-release-8.1 label May 8, 2024

ti-chi-bot mentioned this pull request May 8, 2024

*: individually check the scheduling halt for online unsafe recovery (#8147) #8155

Merged

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request May 20, 2024

This is an automated cherry-pick of tikv#8147

c86fcfb

ref tikv#6493, close tikv#8095 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

ti-chi-bot mentioned this pull request May 20, 2024

*: individually check the scheduling halt for online unsafe recovery (#8147) #8193

Closed

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request May 20, 2024

This is an automated cherry-pick of tikv#8147

9d2a577

ref tikv#6493, close tikv#8095 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

ti-chi-bot mentioned this pull request May 20, 2024

*: individually check the scheduling halt for online unsafe recovery (#8147) #8194

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

*: individually check the scheduling halt for online unsafe recovery #8147

*: individually check the scheduling halt for online unsafe recovery #8147

JmPotato commented May 7, 2024

ti-chi-bot bot commented May 7, 2024 •

edited

codecov bot commented May 7, 2024 •

edited

rleungx May 7, 2024 •

edited

JmPotato May 7, 2024

HuSharp May 8, 2024 •

edited

JmPotato May 8, 2024

JmPotato commented May 8, 2024

ti-chi-bot bot commented May 8, 2024

ti-chi-bot bot commented May 8, 2024

ti-chi-bot commented May 8, 2024

lhy1024 commented May 20, 2024

lhy1024 commented May 20, 2024

ti-chi-bot commented May 20, 2024

ti-chi-bot commented May 20, 2024

*: individually check the scheduling halt for online unsafe recovery #8147

*: individually check the scheduling halt for online unsafe recovery #8147

Conversation

JmPotato commented May 7, 2024

What problem does this PR solve?

What is changed and how does it work?

Check List

Release note

ti-chi-bot bot commented May 7, 2024 • edited

codecov bot commented May 7, 2024 • edited

Codecov Report

rleungx May 7, 2024 • edited

Choose a reason for hiding this comment

JmPotato May 7, 2024

Choose a reason for hiding this comment

HuSharp May 8, 2024 • edited

Choose a reason for hiding this comment

JmPotato May 8, 2024

Choose a reason for hiding this comment

JmPotato commented May 8, 2024

ti-chi-bot bot commented May 8, 2024

ti-chi-bot bot commented May 8, 2024

ti-chi-bot commented May 8, 2024

lhy1024 commented May 20, 2024

lhy1024 commented May 20, 2024

ti-chi-bot commented May 20, 2024

ti-chi-bot commented May 20, 2024

ti-chi-bot bot commented May 7, 2024 •

edited

codecov bot commented May 7, 2024 •

edited

rleungx May 7, 2024 •

edited

HuSharp May 8, 2024 •

edited