Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pdms: support primary/transfer api for scheduling and tso #8148

Closed
wants to merge 2 commits into from

Conversation

HuSharp
Copy link
Member

@HuSharp HuSharp commented May 8, 2024

What problem does this PR solve?

Issue Number: Ref #5766, #7519

What is changed and how does it work?

$ curl --location --request GET 'http://127.0.0.1:2379/pd/api/v2/ms/primary/tso'
"http://127.0.0.1:2384"

$ curl --location --request POST 'http://127.0.0.1:2382/tso/api/v1/member/primary/transfer' \
--header 'service-allow-direct-handle: true'
"transfer submitted!"

$ curl --location --request GET 'http://127.0.0.1:2379/pd/api/v2/ms/primary/tso'
"http://127.0.0.1:2382"

Check List

Tests

  • Unit test
  • Manual test (add detailed scripts or steps below)

Release note

None.

@HuSharp HuSharp requested review from lhy1024 and rleungx May 8, 2024 06:01
Copy link
Contributor

ti-chi-bot bot commented May 8, 2024

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added release-note-none size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 8, 2024
Signed-off-by: husharp <jinhao.hu@pingcap.com>
Signed-off-by: husharp <jinhao.hu@pingcap.com>
@HuSharp HuSharp changed the title pdms: transfer primary api for scheduling and tso pdms: support primary/transfer api for scheduling and tso May 8, 2024
Copy link

codecov bot commented May 8, 2024

Codecov Report

Attention: Patch coverage is 40.36145% with 99 lines in your changes are missing coverage. Please review.

Project coverage is 77.31%. Comparing base (a3c5950) to head (15fc759).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8148      +/-   ##
==========================================
- Coverage   77.35%   77.31%   -0.05%     
==========================================
  Files         471      471              
  Lines       61348    61471     +123     
==========================================
+ Hits        47458    47528      +70     
- Misses      10314    10382      +68     
+ Partials     3576     3561      -15     
Flag Coverage Δ
unittests 77.31% <40.36%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@HuSharp HuSharp requested a review from JmPotato May 8, 2024 07:58
@HuSharp
Copy link
Member Author

HuSharp commented May 9, 2024

replaced by #8157

@HuSharp HuSharp marked this pull request as draft May 9, 2024 03:27
@ti-chi-bot ti-chi-bot bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 9, 2024
@HuSharp HuSharp closed this May 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant