-
Notifications
You must be signed in to change notification settings - Fork 712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools/heartbeat: support to collect metrics #8235
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: husharp <jinhao.hu@pingcap.com>
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8235 +/- ##
==========================================
+ Coverage 77.26% 77.36% +0.10%
==========================================
Files 471 471
Lines 61346 61369 +23
==========================================
+ Hits 47401 47481 +80
+ Misses 10383 10324 -59
- Partials 3562 3564 +2
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: husharp <jinhao.hu@pingcap.com>
tools/pd-heartbeat-bench/main.go
Outdated
c.String(http.StatusBadRequest, "invalid second") | ||
return | ||
} | ||
metrics.InitMetric2Collect(cfg.MetricsAddr) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe there is no monitor if it only runs binaries.
Signed-off-by: husharp <jinhao.hu@pingcap.com>
e678954
to
37d30f6
Compare
What problem does this PR solve?
Issue Number: Ref #8135
What is changed and how does it work?
Check List
Tests
Release note