Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add prow OWNERS files to control the approvals for critical configuration files (#8218) #8248

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #8218

What problem does this PR solve?

Issue Number: Close #8167

What is changed and how does it work?

Check List

Tests

  • No code

Code changes

  • None

Side effects

  • None

Related changes

  • Need to cherry-pick to the release branch: release-8.1, release-7.5, release-7.1, release-6.5, release-6.1

Release note

None.

Close tikv#8167

Signed-off-by: wuhuizuo <wuhuizuo@126.com>
Signed-off-by: wuhuizuo <wuhuizuo@126.com>
Signed-off-by: wuhuizuo <wuhuizuo@126.com>
Signed-off-by: wuhuizuo <wuhuizuo@126.com>
Signed-off-by: wuhuizuo <wuhuizuo@126.com>
Signed-off-by: wuhuizuo <wuhuizuo@126.com>
Signed-off-by: wuhuizuo <wuhuizuo@126.com>
Signed-off-by: wuhuizuo <wuhuizuo@126.com>
Signed-off-by: wuhuizuo <wuhuizuo@126.com>
Signed-off-by: wuhuizuo <wuhuizuo@126.com>
Signed-off-by: wuhuizuo <wuhuizuo@126.com>
Signed-off-by: wuhuizuo <wuhuizuo@126.com>
Copy link
Contributor

ti-chi-bot bot commented Jun 5, 2024

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • HuSharp
  • lhy1024

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 5, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jun 5, 2024
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 7, 2024
@HuSharp
Copy link
Member

HuSharp commented Jun 7, 2024

/merge

Copy link
Contributor

ti-chi-bot bot commented Jun 7, 2024

@HuSharp: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Jun 7, 2024

This pull request has been accepted and is ready to merge.

Commit hash: 00e819d

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 7, 2024
@HuSharp
Copy link
Member

HuSharp commented Jun 7, 2024

/build

@HuSharp
Copy link
Member

HuSharp commented Jun 7, 2024

/test build

Copy link
Contributor

ti-chi-bot bot commented Jun 7, 2024

@HuSharp: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test wip-pull-build-release-6.1

In response to this:

/test build

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot removed the status/can-merge Indicates a PR has been approved by a committer. label Jun 7, 2024
Copy link
Contributor

ti-chi-bot bot commented Jun 7, 2024

Merge canceled because a new commit is pushed.

@lhy1024
Copy link
Contributor

lhy1024 commented Jun 7, 2024

/rebuild

@wuhuizuo
Copy link
Contributor

wuhuizuo commented Jun 8, 2024

/test build

Copy link
Contributor

ti-chi-bot bot commented Jun 8, 2024

@wuhuizuo: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test wip-pull-build-release-6.1

In response to this:

/test build

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wuhuizuo
Copy link
Contributor

wuhuizuo commented Jun 8, 2024

/test wip-pull-build-release-6.1

@wuhuizuo
Copy link
Contributor

wuhuizuo commented Jun 8, 2024

/run-build
/rebuild
/build

@wuhuizuo
Copy link
Contributor

wuhuizuo commented Jun 8, 2024

/run-all-tests

@wuhuizuo
Copy link
Contributor

/run-build

@purelind
Copy link
Contributor

/run-all-tests

1 similar comment
@purelind
Copy link
Contributor

/run-all-tests

@ti-chi-bot ti-chi-bot bot merged commit 75b257e into tikv:release-6.1 Jun 11, 2024
19 checks passed
@HuSharp HuSharp deleted the cherry-pick-8218-to-release-6.1 branch June 11, 2024 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. dco-signoff: yes lgtm ok-to-test release-note-none size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-6.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants