Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools/simulator: avoid redundant schedule #8257

Merged
merged 2 commits into from
Jun 6, 2024

Conversation

HuSharp
Copy link
Member

@HuSharp HuSharp commented Jun 5, 2024

What problem does this PR solve?

Issue Number: Close #5290, Ref #8135

What is changed and how does it work?

renew #5252

Check List

Tests

  • Manual test

Release note

None.

Signed-off-by: husharp <jinhao.hu@pingcap.com>
@HuSharp HuSharp requested review from lhy1024 and rleungx June 5, 2024 09:38
Copy link
Contributor

ti-chi-bot bot commented Jun 5, 2024

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lhy1024

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added release-note-none do-not-merge/needs-triage-completed dco-signoff: yes size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 5, 2024
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 5, 2024
@HuSharp
Copy link
Member Author

HuSharp commented Jun 5, 2024

/check-issue-triage-complete

1 similar comment
@HuSharp
Copy link
Member Author

HuSharp commented Jun 6, 2024

/check-issue-triage-complete

@HuSharp HuSharp added the require-LGT1 Indicates that the PR requires an LGTM. label Jun 6, 2024
@HuSharp
Copy link
Member Author

HuSharp commented Jun 6, 2024

/merge

Copy link
Contributor

ti-chi-bot bot commented Jun 6, 2024

@HuSharp: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Jun 6, 2024

This pull request has been accepted and is ready to merge.

Commit hash: a312a07

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 6, 2024
Copy link
Contributor

ti-chi-bot bot commented Jun 6, 2024

@HuSharp: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit 494c0e9 into tikv:master Jun 6, 2024
16 checks passed
@HuSharp HuSharp deleted the avoid_scheduler branch June 6, 2024 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes release-note-none require-LGT1 Indicates that the PR requires an LGTM. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

simulator should pause scheduler before the store update the status to pd.
2 participants