resource_control: allow configuration of the maximum retry time for the local bucket #8352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
bot
added
do-not-merge/needs-triage-completed
release-note-none
dco-signoff: yes
size/L
nolouch
force-pushed
the
export-config
branch
2 times, most recently
from
66da8b5
to
5a37dc6
Compare
…he local bucket Signed-off-by: nolouch <nolouch@gmail.com>
JmPotato
reviewed
Jul 2, 2024
ti-chi-bot
bot
added
size/XL
JmPotato
reviewed
Jul 2, 2024
Comment on lines
307
to
308
| default: | ||
| select { |
There was a problem hiding this comment.
Suggested change
| default: | |
| select { | |
| default: | |
| } | |
| select { |
This can reduce one level of nesting.
There was a problem hiding this comment.
I removed the changes, and will do it in another PR. Here only introduce the config. cc @JmPotato
Signed-off-by: nolouch <nolouch@gmail.com>
ti-chi-bot
bot
added
size/L
HuSharp
approved these changes
Jul 2, 2024
|
PTAL @JmPotato |
JmPotato
approved these changes
Jul 3, 2024
niubell
approved these changes
Jul 3, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: HuSharp, JmPotato, niubell The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
pushed a commit
to ti-chi-bot/pd
that referenced
this pull request
Jul 4, 2024
close tikv#8349 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
|
In response to a cherrypick label: new pull request created to branch |
|
In response to a cherrypick label: new pull request created to branch |
ti-chi-bot
pushed a commit
to ti-chi-bot/pd
that referenced
this pull request
Jul 4, 2024
close tikv#8349 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
|
/run-cherry-picker |
|
In response to a cherrypick label: new pull request created to branch |
ti-chi-bot
pushed a commit
to ti-chi-bot/pd
that referenced
this pull request
Jul 4, 2024
close tikv#8349 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
|
In response to a cherrypick label: new pull request created to branch |
nolouch
added a commit
to nolouch/pd
that referenced
this pull request
Jul 4, 2024
close tikv#8349 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io> Signed-off-by: nolouch <nolouch@gmail.com>
nolouch
added a commit
to nolouch/pd
that referenced
this pull request
Jul 4, 2024
close tikv#8349 Signed-off-by: nolouch <nolouch@gmail.com>
ti-chi-bot bot
pushed a commit
that referenced
this pull request
Jul 4, 2024
…he local bucket (#8352) (#8364) close #8349 resource_control: allow configuration of the maximum retry time for the local bucket - Added config `ltb-token-rpc-max-delay` - Increased default max delay from 500ms to 1s Signed-off-by: nolouch <nolouch@gmail.com> Co-authored-by: nolouch <nolouch@gmail.com>
ti-chi-bot bot
added a commit
that referenced
this pull request
Jul 4, 2024
…he local bucket (#8352) (#8360) close #8349 resource_control: allow configuration of the maximum retry time for the local bucket - Added config `ltb-token-rpc-max-delay` - Increased default max delay from 500ms to 1s Signed-off-by: nolouch <nolouch@gmail.com> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com> Co-authored-by: nolouch <nolouch@gmail.com>
ti-chi-bot bot
added a commit
that referenced
this pull request
Jul 4, 2024
…he local bucket (#8352) (#8361) close #8349 resource_control: allow configuration of the maximum retry time for the local bucket - Added config `ltb-token-rpc-max-delay` - Increased default max delay from 500ms to 1s Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io> Signed-off-by: nolouch <nolouch@gmail.com> Co-authored-by: ShuNing <nolouch@gmail.com> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com> Co-authored-by: nolouch <nolouch@gmail.com>
nolouch
added a commit
to nolouch/pd
that referenced
this pull request
Jul 4, 2024
close tikv#8349 Signed-off-by: nolouch <nolouch@gmail.com>
nolouch
added a commit
to nolouch/pd
that referenced
this pull request
Jul 4, 2024
close tikv#8349 Signed-off-by: nolouch <nolouch@gmail.com> Signed-off-by: Shuning Chen <nolouch@ShuningdeMacBook-Pro.local>
nolouch
added a commit
that referenced
this pull request
Jul 4, 2024
…he local bucket (#8352) (#8365) * client/controller: record context error and add slowlog about token bucket (#8344) (#8355) close #8343, ref #8349 client/controller: record context error and add slowlog about token bucket - record low process start time, and log it if it's too slow - record the context error Signed-off-by: Shuning Chen <nolouch@ShuningdeMacBook-Pro.local> * This is an automated cherry-pick of #8352 close #8349 Signed-off-by: nolouch <nolouch@gmail.com> Signed-off-by: Shuning Chen <nolouch@ShuningdeMacBook-Pro.local> --------- Signed-off-by: Shuning Chen <nolouch@ShuningdeMacBook-Pro.local> Signed-off-by: nolouch <nolouch@gmail.com> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: Close #8349
What is changed and how does it work?
Check List
Tests
Related changes
pingcap/docs/pingcap/docs-cn:pingcap/tiup:Release note