Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server: count the number of offline region #986

Merged
merged 3 commits into from Mar 10, 2018
Merged

server: count the number of offline region #986

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7afe1c9
server: add offline region statistics
nolouch Mar 9, 2018
39bcfa5
Merge branch 'master' into offline-peer-count
Connor1996 Mar 9, 2018
0d1c757
Merge branch 'master' into offline-peer-count
nolouch Mar 10, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 10 additions & 0 deletions server/region_statistics.go
View file
Open in desktop
Expand Up @@ -25,6 +25,7 @@ const (
extraPeer
downPeer
pendingPeer
offlinePeer
incorrectNamespace
)

Expand All @@ -46,6 +47,7 @@ func newRegionStatistics(opt *scheduleOption, classifier namespace.Classifier) *
r.stats[extraPeer] = make(map[uint64]*core.RegionInfo)
r.stats[downPeer] = make(map[uint64]*core.RegionInfo)
r.stats[pendingPeer] = make(map[uint64]*core.RegionInfo)
r.stats[offlinePeer] = make(map[uint64]*core.RegionInfo)
r.stats[incorrectNamespace] = make(map[uint64]*core.RegionInfo)
return r
}
Expand Down Expand Up @@ -90,6 +92,13 @@ func (r *regionStatistics) Observe(region *core.RegionInfo, stores []*core.Store
peerTypeIndex |= pendingPeer
}
for _, store := range stores {
if store.IsOffline() {
peer := region.GetStorePeer(store.GetId())
if peer != nil {
r.stats[offlinePeer][regionID] = region
peerTypeIndex |= offlinePeer
}
}
ns := r.classifier.GetStoreNamespace(store)
if ns == namespace {
continue
Expand Down Expand Up @@ -155,5 +164,6 @@ func (r *regionStatistics) Collect() {
regionStatusGauge.WithLabelValues("extra_peer_region_count").Set(float64(len(r.stats[extraPeer])))
regionStatusGauge.WithLabelValues("down_peer_region_count").Set(float64(len(r.stats[downPeer])))
regionStatusGauge.WithLabelValues("pending_peer_region_count").Set(float64(len(r.stats[pendingPeer])))
regionStatusGauge.WithLabelValues("offline_peer_region_count").Set(float64(len(r.stats[offlinePeer])))
regionStatusGauge.WithLabelValues("incorrect_namespace_region_count").Set(float64(len(r.stats[incorrectNamespace])))
}
5 changes: 5 additions & 0 deletions server/region_statistics_test.go
View file
Open in desktop
Expand Up @@ -70,6 +70,7 @@ func (t *testRegionStatistcs) TestRegionStatistics(c *C) {
{Peer: peers[0], DownSeconds: 3608},
{Peer: peers[1], DownSeconds: 3608},
}
stores[3].State = metapb.StoreState_Offline
r1 := &metapb.Region{Id: 1, Peers: peers, StartKey: []byte("aa"), EndKey: []byte("bb")}
r2 := &metapb.Region{Id: 2, Peers: peers[0:2], StartKey: []byte("cc"), EndKey: []byte("dd")}
region1 := core.NewRegionInfo(r1, peers[0])
Expand All @@ -91,7 +92,11 @@ func (t *testRegionStatistcs) TestRegionStatistics(c *C) {
c.Assert(len(regionStats.stats[missPeer]), Equals, 1)
c.Assert(len(regionStats.stats[downPeer]), Equals, 2)
c.Assert(len(regionStats.stats[pendingPeer]), Equals, 1)
c.Assert(len(regionStats.stats[offlinePeer]), Equals, 1)
c.Assert(len(regionStats.stats[incorrectNamespace]), Equals, 1)
stores[3].State = metapb.StoreState_Up
regionStats.Observe(region1, stores, nil)
c.Assert(len(regionStats.stats[offlinePeer]), Equals, 0)
}

func (t *testRegionStatistcs) TestRegionLabelIsolationLevel(c *C) {
Expand Down