Migrate to Slog #185

nrc · 2019-02-20T19:57:23Z

Rebased version of #52, based on top of #184

nrc · 2019-02-21T02:52:01Z

rebased

nrc · 2019-02-22T03:29:22Z

Blocked on landing #184

Hoverbear · 2019-02-22T20:02:02Z

@nrc 2018 is merged now. :)

You have some conflicts due to #127

nrc · 2019-02-24T22:33:13Z

rebased again

src/lib.rs

harness/src/lib.rs

src/lib.rs

src/progress.rs

Hoverbear · 2019-04-02T20:43:06Z

@nrc There is a lot of merge conflicts, do you think you could address them?

nrc · 2019-05-21T06:33:17Z

I've rebased and addressed some of the easier review comments (finally, sorry it took so long). I'll address the other comments tomorrow.

nrc · 2019-05-22T00:37:04Z

All comments addressed. @Hoverbear PTAL

src/progress/progress_set.rs

nrc · 2019-05-30T23:23:22Z

@Hoverbear I changed the API as we discussed and the default logger to be sync. PTAL

Cargo.toml

nrc · 2019-06-04T22:57:44Z

Comment addressed and rebased

Signed-off-by: Nick Cameron <nrc@ncameron.org>

Reduces duplication in log messages, avoids `format!("{:?}", ...)`, and makes logging more idiomatic. Signed-off-by: Nick Cameron <nrc@ncameron.org>

nrc · 2019-06-06T21:16:18Z

I've improved the logging strings to eliminate some duplication. I doubt things are perfect, but since we need to fix the messages on an individual basis, I think I've hit a reasonable point of diminishing returns

Hoverbear · 2019-06-06T21:34:24Z

Whoa check out how nice the output of RUST_TEST_THREADS=1 RUST_LOG=raft=debug cargo test -- --nocapture is!

src/raft.rs

Hoverbear · 2019-06-06T22:41:27Z

src/raft.rs

+            msg_index = m.index,
+            term = self.term;
+            "tag" => &self.tag,
+            "msg type" => ?m.msg_type(),


@breeswish Does this naming style seem ok with you? (spaces in the slog values)

src/raft.rs

src/raft_log.rs

tests/integration_cases/test_membership_changes.rs

Co-Authored-By: Ana Hobden <operator@hoverbear.org> Signed-off-by: Nick Cameron <nrc@ncameron.org>

Hoverbear · 2019-06-10T19:45:03Z

@breeswish PTAL

breezewish

Cool!

nrc requested a review from Hoverbear February 20, 2019 19:57

nrc force-pushed the slog branch from c4a8805 to d214d3a Compare February 21, 2019 02:51

nrc force-pushed the slog branch from d214d3a to fcc5b5b Compare February 24, 2019 22:31

nrc force-pushed the slog branch 2 times, most recently from 90f101a to 361b15c Compare February 25, 2019 03:53

Hoverbear reviewed Feb 25, 2019

View reviewed changes

Hoverbear added this to the 0.6.0 milestone Feb 25, 2019

Hoverbear mentioned this pull request Feb 25, 2019

*: Introduce slog #52

Closed

Hoverbear assigned nrc Apr 9, 2019

Hoverbear added the Feature Related to a major feature. label Apr 9, 2019

nrc force-pushed the slog branch 3 times, most recently from 37bfe5d to 82aba5c Compare May 21, 2019 06:25

nrc force-pushed the slog branch 2 times, most recently from a033606 to 501478d Compare May 22, 2019 00:36

Hoverbear reviewed May 27, 2019

View reviewed changes

src/progress/progress_set.rs Outdated Show resolved Hide resolved

nrc force-pushed the slog branch 3 times, most recently from 54e70d8 to cb087cb Compare May 30, 2019 22:14

Hoverbear reviewed Jun 4, 2019

View reviewed changes

Cargo.toml Outdated Show resolved Hide resolved

nrc force-pushed the slog branch from cb087cb to 41015e3 Compare June 4, 2019 22:56

Hoverbear and others added 7 commits June 7, 2019 08:06

*: Introduce slog

3ffa31d

Address unused variable warnings

fd4c1ee

Convert five node example to slog

febcaf7

Rebasing

32afbbb

Address review comments

2ec1b77

Signed-off-by: Nick Cameron <nrc@ncameron.org>

Use a builder-style API to set the logger

21fb16f

Signed-off-by: Nick Cameron <nrc@ncameron.org>

Make better use of slog formatting

868bba6

Reduces duplication in log messages, avoids `format!("{:?}", ...)`, and makes logging more idiomatic. Signed-off-by: Nick Cameron <nrc@ncameron.org>

nrc force-pushed the slog branch from 69398f1 to 868bba6 Compare June 6, 2019 21:14

Hoverbear requested a review from hicqu June 6, 2019 21:33