Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DNM] RFC: keyspace level GC #113

Open
wants to merge 51 commits into
base: master
Choose a base branch
from
Open

[DNM] RFC: keyspace level GC #113

wants to merge 51 commits into from

Conversation

ystaticy
Copy link

No description provided.

@ystaticy
ks_level_gc init commit
57aef25 
Signed-off-by: y_static_y@sina.com <y_static_y@sina.com>
This was referenced Apr 24, 2024
Open
Open
@ystaticy
in check consistency and trigger compaction
b2e017a 
Signed-off-by: y_static_y@sina.com <y_static_y@sina.com>
@ystaticy
fix words
3e5f711 
Signed-off-by: y_static_y@sina.com <y_static_y@sina.com>
@ystaticy
fix words
9196bce 
Signed-off-by: y_static_y@sina.com <y_static_y@sina.com>
@ystaticy
fix words
9e72539 
Signed-off-by: y_static_y@sina.com <y_static_y@sina.com>
@ystaticy
fix words
e90dd88 
Signed-off-by: y_static_y@sina.com <y_static_y@sina.com>
@ystaticy
fix words
0900f46 
Signed-off-by: y_static_y@sina.com <y_static_y@sina.com>
@ystaticy
add link
2dce1cc 
Signed-off-by: y_static_y@sina.com <y_static_y@sina.com>
@ystaticy
format
09181ad 
Signed-off-by: y_static_y@sina.com <y_static_y@sina.com>
Connor1996
Connor1996 reviewed Apr 30, 2024
View reviewed changes
text/0113-keyspace-level-gc.md Show resolved Hide resolved
text/0113-keyspace-level-gc.md Outdated Show resolved Hide resolved
@ystaticy
add details for optimize trigger timing and assert judgment
b97f612 
Signed-off-by: y_static_y@sina.com <y_static_y@sina.com>
@ystaticy
add details
3689a4d 
Signed-off-by: y_static_y@sina.com <y_static_y@sina.com>
Connor1996
Connor1996 approved these changes May 6, 2024
View reviewed changes
Copy link
Member

@Connor1996 Connor1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pingyu
pingyu reviewed May 9, 2024
View reviewed changes
Copy link
Contributor

@pingyu pingyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do other services, e.g, BR (especial global BR) & CDC, adapt to this feature ?

text/0113-keyspace-level-gc.md Outdated Show resolved Hide resolved
text/0113-keyspace-level-gc.md Outdated Show resolved Hide resolved
text/0113-keyspace-level-gc.md Outdated Show resolved Hide resolved
text/0113-keyspace-level-gc.md Outdated Show resolved Hide resolved
text/0113-keyspace-level-gc.md Outdated Show resolved Hide resolved
text/0113-keyspace-level-gc.md Outdated Show resolved Hide resolved
text/0113-keyspace-level-gc.md Outdated Show resolved Hide resolved
text/0113-keyspace-level-gc.md Outdated Show resolved Hide resolved
text/0113-keyspace-level-gc.md Outdated Show resolved Hide resolved
text/0113-keyspace-level-gc.md Outdated Show resolved Hide resolved
@ystaticy
fix comments
a964053 
Signed-off-by: y_static_y@sina.com <y_static_y@sina.com>
@ystaticy
fix comments
342a08d 
Signed-off-by: y_static_y@sina.com <y_static_y@sina.com>
@ystaticy
fix comments
9c5d786 
Signed-off-by: y_static_y@sina.com <y_static_y@sina.com>
@ystaticy
fix comments
24b2ff8 
Signed-off-by: y_static_y@sina.com <y_static_y@sina.com>
@ystaticy
fix comments
73afd99 
Signed-off-by: y_static_y@sina.com <y_static_y@sina.com>
@ystaticy
add Usage and Compatibility
1b4af39 
Signed-off-by: y_static_y@sina.com <y_static_y@sina.com>
@ystaticy
fix comments
3f2582a 
Signed-off-by: y_static_y@sina.com <y_static_y@sina.com>
@ystaticy
Copy link
Author

How do other services, e.g, BR (especial global BR) & CDC, adapt to this feature ?

@pingyu Other services are adapted in pingcap/tidb, mainly when importing and exporting keyspace data, and using the safe point v2 interface if keyspace level GC is enabled in the keyspace. There is no need to modify the logic of TiKV. So it is not described here.

CDC does not yet support specifying keyspaces, so this will not be changed at this time.

ystaticy and others added 6 commits May 10, 2024 11:24
@ystaticy
fix
0a63d88 
Signed-off-by: y_static_y@sina.com <y_static_y@sina.com>
@ystaticy
fix pick
fb72c0c 
Signed-off-by: y_static_y@sina.com <y_static_y@sina.com>
@ystaticy
add upgrade,remove Other non-GC logic desc
e09dd1e 
Signed-off-by: y_static_y@sina.com <y_static_y@sina.com>
@ystaticy
update img
d68bf14 
Signed-off-by: y_static_y@sina.com <y_static_y@sina.com>
@ystaticy
update img
9607e07 
Signed-off-by: y_static_y@sina.com <y_static_y@sina.com>
@baiyuqing
fix lint
57ad936 
Signed-off-by: baiyuqing <baiyuq@gmail.com>
ystaticy and others added 10 commits May 10, 2024 15:44
@ystaticy
add desc about global br
2d3ea11 
Signed-off-by: y_static_y@sina.com <y_static_y@sina.com>
@baiyuqing
Merge branch 'ks_level_gc' into ks_level_gc
6bbc412
@baiyuqing
update
c81e9b4 
Signed-off-by: baiyuqing <baiyuq@gmail.com>
@baiyuqing
update
f28ae09 
Signed-off-by: baiyuqing <baiyuq@gmail.com>
@baiyuqing
update
3f73fde 
Signed-off-by: baiyuqing <baiyuq@gmail.com>
@baiyuqing
update formula
05b2639 
Signed-off-by: baiyuqing <baiyuq@gmail.com>
@baiyuqing
update formula
bc2f253 
Signed-off-by: baiyuqing <baiyuq@gmail.com>
@baiyuqing
update
445f0dc 
Signed-off-by: baiyuqing <baiyuq@gmail.com>
@baiyuqing
update
9e61246 
Signed-off-by: baiyuqing <baiyuq@gmail.com>
@baiyuqing
fix
86be4c7 
Signed-off-by: baiyuqing <baiyuq@gmail.com>
@ystaticy ystaticy changed the title RFC: keyspace level gc [DNM] RFC: keyspace level gc May 16, 2024
@ystaticy
Merge pull request #1 from baiyuqing/ks_level_gc
fc80f72
@ystaticy
update Motivation
ee41238 
Signed-off-by: y_static_y@sina.com <y_static_y@sina.com>
@ystaticy
add
e649fdc 
Signed-off-by: y_static_y@sina.com <y_static_y@sina.com>
@ystaticy
add link for keyspace meta
2aeadf6 
Signed-off-by: y_static_y@sina.com <y_static_y@sina.com>
@ystaticy ystaticy changed the title [DNM] RFC: keyspace level gc [DNM] RFC: keyspace level GC Jun 12, 2024
pingyu
pingyu reviewed Jun 12, 2024
View reviewed changes
text/0113-keyspace-level-gc.md Outdated Show resolved Hide resolved
text/0113-keyspace-level-gc.md Outdated Show resolved Hide resolved
text/0113-keyspace-level-gc.md Outdated Show resolved Hide resolved
text/0113-keyspace-level-gc.md Outdated Show resolved Hide resolved
text/0113-keyspace-level-gc.md Outdated Show resolved Hide resolved
text/0113-keyspace-level-gc.md Outdated Show resolved Hide resolved
text/0113-keyspace-level-gc.md Outdated Show resolved Hide resolved
text/0113-keyspace-level-gc.md Outdated Show resolved Hide resolved
text/0113-keyspace-level-gc.md Outdated Show resolved Hide resolved
text/0113-keyspace-level-gc.md Outdated Show resolved Hide resolved
@ystaticy
Modify the flow chart
0ad04a3 
Signed-off-by: y_static_y@sina.com <y_static_y@sina.com>
@ystaticy
Modify the flow chart
14b77b9 
Signed-off-by: y_static_y@sina.com <y_static_y@sina.com>
@ystaticy
fix comments
7ddf7f8 
Signed-off-by: y_static_y@sina.com <y_static_y@sina.com>
@ystaticy
fix comments
443a604 
Signed-off-by: y_static_y@sina.com <y_static_y@sina.com>
@ystaticy
fix comments
deba759 
Signed-off-by: y_static_y@sina.com <y_static_y@sina.com>
@ystaticy
fix comments
4d637c8 
Signed-off-by: y_static_y@sina.com <y_static_y@sina.com>
@ystaticy
fix comments
dc3fc5f 
Signed-off-by: y_static_y@sina.com <y_static_y@sina.com>
@ystaticy
fix comments
ba23bed 
Signed-off-by: y_static_y@sina.com <y_static_y@sina.com>
@ystaticy
fix comments
6a2f6ae 
Signed-off-by: y_static_y@sina.com <y_static_y@sina.com>
@ystaticy
fix comments
803465c 
Signed-off-by: y_static_y@sina.com <y_static_y@sina.com>
@ystaticy
fix comments
22f4892 
Signed-off-by: y_static_y@sina.com <y_static_y@sina.com>
pingyu
pingyu approved these changes Jun 12, 2024
View reviewed changes
Copy link
Contributor

@pingyu pingyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pingyu pingyu pingyu approved these changes

@baiyuqing baiyuqing baiyuqing approved these changes

@Connor1996 Connor1996 Connor1996 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ystaticy @pingyu @baiyuqing @Connor1996