benches: move to criterion-rs and GitHub actions #366
Conversation
lucab
force-pushed
the
ups/criterion-benches
branch
from
0b8dfb5
to
51a5397
Compare
|
This was green on my fork: https://github.com/lucab/rust-prometheus/actions/runs/349778558 |
.travis.yml
Outdated
| @@ -46,6 +40,5 @@ script: | |||
| cargo test -p prometheus-static-metric --no-default-features --features="$FEATURES" | |||
|
|
|||
| # Run benchmarks. | |||
| cargo bench --no-default-features --features="$FEATURES" | |||
| cargo bench -p prometheus-static-metric --no-default-features --features="$FEATURES" | |||
There was a problem hiding this comment.
I am a bit reluctant to only partially move to criterion. Is there something blocking us from using criterion in prometheus-static-metric as well?
There was a problem hiding this comment.
Maybe because prometheus-static-metric itself is something that requires nightly?
There was a problem hiding this comment.
No sorry, I just ran out of time on Friday and preferred to split the move into smaller bits. I saw today that there wasn't too much left to be converted, so I amended this PR now to complete the move.
This moves all benches to criterion-rs, in order to allow running benchmarks on a stable toolchain. This also moves benchmarking and linting jobs to a pinned toolchain, under GitHub actions. Signed-off-by: Luca BRUNO <luca.bruno@coreos.com>
lucab
force-pushed
the
ups/criterion-benches
branch
from
6591bd8
to
a12f22c
Compare
|
This should be ready for another round of reviews. Checks will not show up here until the workflow is merged first, but they were green on my fork: https://github.com/lucab/rust-prometheus/actions/runs/353547239 |
This moves all benches to criterion-rs, in order to allow running
benchmarks on a stable toolchain.
This also moves benchmarking and linting jobs to a pinned toolchain,
under GitHub actions.