process_collector: fix compilation on 32-bit targets #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedisct1
added a commit
to DNSCrypt/encrypted-dns-server
that referenced
this pull request
Jun 24, 2022
This is extremely useful, in particular to watch the number of file descriptors used by the application. Unfortunately, the prometheus crate is currently broken on 32-bit platforms. For that reason, Until tikv/rust-prometheus#446 is merged, we have to use a fork on that crate.
|
LGTM, thanks for the patch, can you please sign-off your commit? |
The crate didn't compile on 32-bit targets any more due to libc::sysconf() returning a 32-bit value on those targets. Signed-off-by: Frank Denis <github@pureftpd.org>
Done! |
lucab
approved these changes
Jun 27, 2022
|
ping @lucab @overvenus, Could you please publish this to crates.io ? |
|
@yinheli meanwhile your can use the |
JanBerktold
pushed a commit
to JanBerktold/rust-prometheus
that referenced
this pull request
Nov 12, 2022
The crate didn't compile on 32-bit targets any more due to libc::sysconf() returning a 32-bit value on those targets. Signed-off-by: Frank Denis <github@pureftpd.org> Signed-off-by: Jan Berktold <jberktold@roblox.com>
JanBerktold
pushed a commit
to JanBerktold/rust-prometheus
that referenced
this pull request
Nov 12, 2022
The crate didn't compile on 32-bit targets any more due to libc::sysconf() returning a 32-bit value on those targets. Signed-off-by: Frank Denis <github@pureftpd.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The crate didn't compile on 32-bit targets any more due to
libc::sysconf()returning a 32-bit value on those targets.Fixes #442