[DNM] import sst reader for rocksdb 5.8 #164
Conversation
UncP
changed the title
librocksdb_sys/src/lib.rs
Outdated
| pub fn crocksdb_sstfilereader_read_table_properties( | ||
| reader: *mut SstFileReader, | ||
| ) -> *mut DBTableProperties; | ||
| pub fn crocksdb_sstfilereader_destroy(reader: *mut SstFileReader); |
There was a problem hiding this comment.
We don't need to, we can directly get the offset and the size of seq no, change that int the sst file.
There was a problem hiding this comment.
this is a common feature, we should support it.
There was a problem hiding this comment.
I don't think we can get k-v since rocksdb has no related api for SstFileReader.
There was a problem hiding this comment.
There was a problem hiding this comment.
I saw that before, this is a callback, we still can't get k-v. The callback is used in SstFileReader, do you mean add this callback api?
|
@huachaohuang PTAL at tests/test_rocksdb_options::test_block_based_options, this test failed. left and right are 0, this pr based on rocksdb 5.8. |
|
@UncP RocksDB 5.8 adds some other statistics enums, which invalidate our |
|
this pr has become #173. |
update titan to include tikv/titan#169 for tikv-4.x include the following changes ``` 81814ec 2020-06-04 zbk602423539@gmail.. Fix GC may delete a already deleted blob file (#168) (#169) 80657c0 2020-06-04 zbk602423539@gmail.. Fix wrong assert delta < 0 for cocurrent compaction while flush (#172) (#176) 0db7976 2020-06-04 sre-bot@pingcap.com Fix wrong live data size when encounter rewrite failure (#161) (#175) c41f2a2 2020-06-04 sre-bot@pingcap.com feat: Titan should return user value to compaction filter #163 (#164) (#174) ``` Signed-off-by: sre-bot <sre-bot@pingcap.com>
No description provided.