cherry pick #8016 to release-4.0

Signed-off-by: linning <linningde25@gmail.com>

src/server/config.rs

@@ -198,19 +198,19 @@ impl Config {
             box_try!(config::check_addr(&self.status_addr));
             if !self.advertise_status_addr.is_empty() {
                 box_try!(config::check_addr(&self.advertise_status_addr));
+                if self.advertise_status_addr.starts_with("0.0.0.0") {
+                    return Err(box_err!(
+                        "invalid advertise-status-addr: {:?}",
+                        self.advertise_status_addr
+                    ));
+                }
             } else {
                 info!(
                     "no advertise-status-addr is specified, falling back to status-addr";
                     "status-addr" => %self.status_addr
                 );
                 self.advertise_status_addr = self.status_addr.clone();
             }
-            if self.advertise_status_addr.starts_with("0.0.0.0") {
-                return Err(box_err!(
-                    "invalid advertise-status-addr: {:?}",
-                    self.advertise_status_addr
-                ));
-            }
         }
         if self.advertise_status_addr == self.advertise_addr {
             return Err(box_err!(
@@ -339,9 +339,9 @@ mod tests {
 
         invalid_cfg = Config::default();
         invalid_cfg.status_addr = "0.0.0.0:1000".to_owned();
-        assert!(invalid_cfg.validate().is_err());
-        invalid_cfg.advertise_status_addr = "127.0.0.1:1000".to_owned();
         invalid_cfg.validate().unwrap();
+        invalid_cfg.advertise_status_addr = "0.0.0.0:1000".to_owned();
+        assert!(invalid_cfg.validate().is_err());
 
         let mut invalid_cfg = cfg.clone();
         invalid_cfg.advertise_addr = "127.0.0.1:1000".to_owned();

src/server/status_server.rs

@@ -609,16 +609,19 @@ impl StatusServer {
                         self.advertise_addr = Some(advertise_addr);
                         return;
                     }
-                    Ok(resp) => error!("failed to register addr to pd"; "response" => ?resp),
-                    Err(e) => error!("failed to register addr to pd"; "error" => ?e),
+                    Ok(resp) => {
+                        let status = resp.status();
+                        warn!("failed to register addr to pd"; "status code" => status.as_str(), "body" => ?resp.text());
+                    }
+                    Err(e) => warn!("failed to register addr to pd"; "error" => ?e),
                 }
             }
             // refresh the pd leader
             if let Err(e) = pd_client.reconnect() {
-                error!("failed to reconnect pd client"; "err" => ?e);
+                warn!("failed to reconnect pd client"; "err" => ?e);
             }
         }
-        error!(
+        warn!(
             "failed to register addr to pd after {} tries",
             COMPONENT_REQUEST_RETRY
         );
@@ -642,16 +645,19 @@ impl StatusServer {
                         self.advertise_addr = None;
                         return;
                     }
-                    Ok(resp) => error!("failed to unregister addr to pd"; "response" => ?resp),
-                    Err(e) => error!("failed to unregister addr to pd"; "error" => ?e),
+                    Ok(resp) => {
+                        let status = resp.status();
+                        warn!("failed to unregister addr to pd"; "status code" => status.as_str(), "body" => ?resp.text());
+                    }
+                    Err(e) => warn!("failed to unregister addr to pd"; "error" => ?e),
                 }
             }
             // refresh the pd leader
             if let Err(e) = pd_client.reconnect() {
-                error!("failed to reconnect pd client"; "err" => ?e);
+                warn!("failed to reconnect pd client"; "err" => ?e);
             }
         }
-        error!(
+        warn!(
             "failed to unregister addr to pd after {} tries",
             COMPONENT_REQUEST_RETRY
         );