server: Fix heap profile temp file is dropped before reading (#16171)

close #16169

Fix heap profile temp file is dropped before reading

Signed-off-by: Connor1996 <zbk602423539@gmail.com>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>

src/server/status_server/mod.rs

@@ -136,10 +136,11 @@ where
         let use_jeprof = query_pairs.get("jeprof").map(|x| x.as_ref()) == Some("true");
 
         let result = {
-            let path = match dump_one_heap_profile() {
-                Ok(path) => path,
+            let file = match dump_one_heap_profile() {
+                Ok(file) => file,
                 Err(e) => return Ok(make_response(StatusCode::INTERNAL_SERVER_ERROR, e)),
             };
+            let path = file.path();
             if use_jeprof {
                 jeprof_heap_profile(path.to_str().unwrap())
             } else {
@@ -1561,7 +1562,6 @@ mod tests {
 
     #[cfg(feature = "mem-profiling")]
     #[test]
-    #[ignore]
     fn test_pprof_heap_service() {
         let mut status_server = StatusServer::new(
             1,

src/server/status_server/profile.rs

@@ -2,7 +2,6 @@
 use std::{
     fs::File,
     io::{Read, Write},
-    path::PathBuf,
     pin::Pin,
     process::{Command, Stdio},
     sync::Mutex,
@@ -83,11 +82,11 @@ impl<I, T> Future for ProfileRunner<I, T> {
 }
 
 /// Trigger a heap profile and return the content.
-pub fn dump_one_heap_profile() -> Result<PathBuf, String> {
+pub fn dump_one_heap_profile() -> Result<NamedTempFile, String> {
     let f = NamedTempFile::new().map_err(|e| format!("create tmp file fail: {}", e))?;
     let path = f.path();
     dump_prof(path.to_str().unwrap()).map_err(|e| format!("dump_prof: {}", e))?;
-    Ok(path.to_owned())
+    Ok(f)
 }
 
 /// Trigger one cpu profile.