deal comments in PR

Signed-off-by: joccau <zak.zhao@pingcap.com>
tikv · Mar 17, 2023 · 731b339 · 731b339
1 parent a516a43
commit 731b339
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/components/sst_importer/src/sst_importer.rs b/components/sst_importer/src/sst_importer.rs
@@ -590,7 +590,7 @@ impl SstImporter {
         Ok(())
     }
 
-    pub fn update_config_memory_use_ratio(&self, cfg_mgr: ImportConfigManager) {
+    pub fn update_config_memory_use_ratio(&self, cfg_mgr: &ImportConfigManager) {
         let mem_ratio = cfg_mgr.read().unwrap().memory_use_ratio;
         let memory_limit = Self::calcualte_usage_mem(mem_ratio);
 
@@ -2000,7 +2000,7 @@ mod tests {
         // create config manager and update config.
         let mut cfg_mgr = ImportConfigManager::new(cfg);
         cfg_mgr.dispatch(change).unwrap();
-        importer.update_config_memory_use_ratio(cfg_mgr);
+        importer.update_config_memory_use_ratio(&cfg_mgr);
 
         let mem_limit_new = importer.mem_limit.load(Ordering::SeqCst);
         assert!(mem_limit_old > mem_limit_new);

diff --git a/src/import/sst_service.rs b/src/import/sst_service.rs
@@ -321,7 +321,7 @@ impl<E: Engine> ImportSstService<E> {
         loop {
             sleep(Duration::from_secs(10)).await;
 
-            importer.update_config_memory_use_ratio(cfg.clone());
+            importer.update_config_memory_use_ratio(&cfg);
             importer.shrink_by_tick();
         }
     }
@@ -553,7 +553,7 @@ macro_rules! impl_write {
             let tablets = self.tablets.clone();
             let (rx, buf_driver) = create_stream_with_buffer(
                 stream,
-                self.cfg.0.as_ref().read().unwrap().stream_channel_window,
+                self.cfg.read().unwrap().stream_channel_window,
             );
             let mut rx = rx.map_err(Error::from);