Skip to content

Commit

Permalink
Update sysinfo dependency
Browse files Browse the repository at this point in the history
Signed-off-by: Daniël van Eeden <git@myname.nl>
  • Loading branch information
dveeden committed Dec 6, 2022
1 parent 280d53b commit eb03e66
Show file tree
Hide file tree
Showing 6 changed files with 39 additions and 50 deletions.
24 changes: 8 additions & 16 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ smallvec = "1.4"
sst_importer = { workspace = true }
strum = { version = "0.20", features = ["derive"] }
sync_wrapper = "0.1.1"
sysinfo = "0.16"
sysinfo = "0.26"
tempfile = "3.0"
thiserror = "1.0"
tidb_query_aggr = { workspace = true }
Expand Down
2 changes: 1 addition & 1 deletion components/tikv_util/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ slog-async = "2.3"
slog-global = { version = "0.1", git = "https://github.com/breeswish/slog-global.git", rev = "d592f88e4dbba5eb439998463054f1a44fbf17b9" }
slog-json = "2.3"
slog-term = "2.4"
sysinfo = "0.16"
sysinfo = "0.26"
thiserror = "1.0"
tikv_alloc = { workspace = true }
time = "0.1"
Expand Down
4 changes: 2 additions & 2 deletions components/tikv_util/src/sys/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ use lazy_static::lazy_static;
#[cfg(target_os = "linux")]
use mnt::get_mount;
use sysinfo::RefreshKind;
pub use sysinfo::{DiskExt, NetworkExt, ProcessExt, ProcessorExt, SystemExt};
pub use sysinfo::{CpuExt, DiskExt, NetworkExt, ProcessExt, SystemExt};

use crate::config::{ReadableSize, KIB};

Expand Down Expand Up @@ -92,7 +92,7 @@ impl SysQuota {

fn sysinfo_memory_limit_in_bytes() -> u64 {
let system = sysinfo::System::new_with_specifics(RefreshKind::new().with_memory());
system.get_total_memory() * KIB
system.total_memory() * KIB
}
}

Expand Down
2 changes: 1 addition & 1 deletion src/server/service/diagnostics/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ impl Diagnostics for Service {
let load = (
sys::cpu_time_snapshot(),
system
.get_networks()
.networks()
.into_iter()
.map(|(n, d)| (n.to_owned(), sys::NicSnapshot::from_network_data(d)))
.collect(),
Expand Down
55 changes: 26 additions & 29 deletions src/server/service/diagnostics/sys.rs
Original file line number Diff line number Diff line change
Expand Up @@ -26,12 +26,12 @@ pub struct NicSnapshot {
impl NicSnapshot {
pub fn from_network_data(data: &impl NetworkExt) -> NicSnapshot {
NicSnapshot {
rx_bytes: data.get_total_received(),
tx_bytes: data.get_total_transmitted(),
rx_packets: data.get_total_packets_received(),
tx_packets: data.get_total_packets_transmitted(),
rx_errors: data.get_total_errors_on_received(),
tx_errors: data.get_total_errors_on_transmitted(),
rx_bytes: data.total_received(),
tx_bytes: data.total_transmitted(),
rx_packets: data.total_packets_received(),
tx_packets: data.total_packets_transmitted(),
rx_errors: data.total_errors_on_received(),
tx_errors: data.total_errors_on_transmitted(),
}
}

Expand Down Expand Up @@ -62,7 +62,7 @@ fn cpu_load_info(prev_cpu: CpuTimeSnapshot, collector: &mut Vec<ServerInfoItem>)
let infos = {
let mut system = SYS_INFO.lock().unwrap();
system.refresh_system();
let load = system.get_load_average();
let load = system.load_average();
vec![
("load1", load.one),
("load5", load.five),
Expand Down Expand Up @@ -129,12 +129,12 @@ fn cpu_load_info(prev_cpu: CpuTimeSnapshot, collector: &mut Vec<ServerInfoItem>)
fn mem_load_info(collector: &mut Vec<ServerInfoItem>) {
let mut system = SYS_INFO.lock().unwrap();
system.refresh_memory();
let total_memory = system.get_total_memory() * KIB;
let used_memory = system.get_used_memory() * KIB;
let free_memory = system.get_free_memory() * KIB;
let total_swap = system.get_total_swap() * KIB;
let used_swap = system.get_used_swap() * KIB;
let free_swap = system.get_free_swap() * KIB;
let total_memory = system.total_memory() * KIB;
let used_memory = system.used_memory() * KIB;
let free_memory = system.free_memory() * KIB;
let total_swap = system.total_swap() * KIB;
let used_swap = system.used_swap() * KIB;
let free_swap = system.free_swap() * KIB;
drop(system);
let used_memory_pct = (used_memory as f64) / (total_memory as f64);
let free_memory_pct = (free_memory as f64) / (total_memory as f64);
Expand Down Expand Up @@ -182,7 +182,7 @@ fn nic_load_info(prev_nic: HashMap<String, NicSnapshot>, collector: &mut Vec<Ser
let mut system = SYS_INFO.lock().unwrap();
system.refresh_networks_list();
system.refresh_networks();
let current = system.get_networks();
let current = system.networks();

for (name, cur) in current {
let prev = match prev_nic.get(name) {
Expand Down Expand Up @@ -294,15 +294,15 @@ pub fn load_info(
fn cpu_hardware_info(collector: &mut Vec<ServerInfoItem>) {
let mut system = SYS_INFO.lock().unwrap();
system.refresh_cpu();
let processor = match system.get_processors().iter().next() {
let processor = match system.cpus().iter().next() {
Some(p) => p,
None => return,
};
let mut infos = vec![
("cpu-logical-cores", SysQuota::cpu_cores_quota().to_string()),
("cpu-physical-cores", num_cpus::get_physical().to_string()),
("cpu-frequency", format!("{}MHz", processor.get_frequency())),
("cpu-vendor-id", processor.get_vendor_id().to_string()),
("cpu-frequency", format!("{}MHz", processor.frequency())),
("cpu-vendor-id", processor.vendor_id().to_string()),
];
// Depend on Rust lib return CPU arch not matching
// Golang lib so need this match loop to conversion
Expand Down Expand Up @@ -362,26 +362,23 @@ fn disk_hardware_info(collector: &mut Vec<ServerInfoItem>) {
let mut system = SYS_INFO.lock().unwrap();
system.refresh_disks_list();
system.refresh_disks();
let disks = system.get_disks();
let disks = system.disks();
for disk in disks {
let file_sys = std::str::from_utf8(disk.get_file_system()).unwrap_or("unknown");
let file_sys = std::str::from_utf8(disk.file_system()).unwrap_or("unknown");
if file_sys == "rootfs" {
continue;
}
let total = disk.get_total_space();
let free = disk.get_available_space();
let total = disk.total_space();
let free = disk.available_space();
let used = total - free;
let free_pct = (free as f64) / (total as f64);
let used_pct = (used as f64) / (total as f64);
let infos = vec![
("type", format!("{:?}", disk.get_type())),
("type", format!("{:?}", disk.type_())),
("fstype", file_sys.to_string()),
(
"path",
disk.get_mount_point()
.to_str()
.unwrap_or("unknown")
.to_string(),
disk.mount_point().to_str().unwrap_or("unknown").to_string(),
),
("total", total.to_string()),
("free", free.to_string()),
Expand All @@ -398,7 +395,7 @@ fn disk_hardware_info(collector: &mut Vec<ServerInfoItem>) {
}
let mut item = ServerInfoItem::default();
item.set_tp("disk".to_string());
item.set_name(disk.get_name().to_str().unwrap_or("disk").to_string());
item.set_name(disk.name().to_str().unwrap_or("disk").to_string());
item.set_pairs(pairs.into());
collector.push(item);
}
Expand Down Expand Up @@ -515,7 +512,7 @@ fn get_transparent_hugepage() -> Option<ServerInfoItem> {
pub fn process_info(collector: &mut Vec<ServerInfoItem>) {
let mut system = SYS_INFO.lock().unwrap();
system.refresh_processes();
let processes = system.get_processes();
let processes = system.processes();
for (pid, p) in processes.iter() {
if p.cmd().is_empty() {
continue;
Expand Down Expand Up @@ -555,7 +552,7 @@ mod tests {
system.refresh_networks_list();
system.refresh_all();
system
.get_networks()
.networks()
.into_iter()
.map(|(n, d)| (n.to_owned(), NicSnapshot::from_network_data(d)))
.collect()
Expand Down

0 comments on commit eb03e66

Please sign in to comment.