Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CDC fetching old values utilizes too much CPU #11557

Closed
hicqu opened this issue Dec 3, 2021 · 1 comment · Fixed by #11615
Closed

CDC fetching old values utilizes too much CPU #11557

hicqu opened this issue Dec 3, 2021 · 1 comment · Fixed by #11615
Assignees
@hicqu
Labels
type/enhancement Type: Issue - Enhancement

Comments

@hicqu
Copy link
Contributor

hicqu commented Dec 3, 2021

Development Task

It's introduced in #11385. For a CDC incremental scan with hint_min_ts activated, long old values (not inlined in write CF) are fetched from default CF with rocksdb::get call, which utilizes too much CPU. However without hint_min_ts those old values are fetched with Cursor::near_seek, which should be a better policy.
@hicqu hicqu added the type/enhancement Type: Issue - Enhancement label Dec 3, 2021
@hicqu hicqu self-assigned this Dec 3, 2021
@hicqu
Copy link
Contributor Author

hicqu commented Dec 3, 2021

Here is a CPU profile about the problem: with-ts-filter.xml.zip

@hicqu hicqu mentioned this issue Dec 8, 2021
Merged
hicqu added a commit to hicqu/tikv that referenced this issue Dec 8, 2021
@hicqu
close tikv#11557
c478e2c 
Signed-off-by: qupeng <qupeng@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hicqu hicqu

Labels
type/enhancement Type: Issue - Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cdc: load uninlined value more effectively hicqu/tikv
1 participant
@hicqu