Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log-Backup: Tracking Issue for Removing Checkpoint V2 Codebase from TiKV #13196

Open
4 tasks
YuJuncen opened this issue Aug 1, 2022 · 0 comments
Open
4 tasks

Log-Backup: Tracking Issue for Removing Checkpoint V2 Codebase from TiKV #13196

YuJuncen opened this issue Aug 1, 2022 · 0 comments
Labels
type/enhancement Type: Issue - Enhancement

Comments

@YuJuncen
Copy link
Contributor

YuJuncen commented Aug 1, 2022 •
edited

Development Task

After adapting checkpoint V3, there is no need for keeping the poor old checkpoint model. In the 6.2 release, the config use_checkpoint_v3 would always be true. We can move the code of checkpoint V2 from the codebase.

Generally, there are some steps:

  • Adapt the tests: removing tests spec for checkpoint V2 and fix failure cases when using V3.
  • subscription_tracer no more needs to support state transforming.
  • checkpoint_manager::CheckpointV2FlushObserver can be removed now.
  • Uploading region level checkpoint to meta_client can be removed now.

A Note: Compatibility

Checkpoint V2 isn't officially released.

If some in-use cluster wants to upgrade to V3, we can always stop the task when updating and do a full backup, start the task again after update succeed. There isn't an intermediate state in updating from V2 to V3 in that condition.
@YuJuncen YuJuncen added the type/enhancement Type: Issue - Enhancement label Aug 1, 2022
@YuJuncen YuJuncen mentioned this issue Aug 1, 2022
Merged
@YuJuncen YuJuncen changed the title Tracking Issue for Removing Checkpoint V2 Codebase from TiKV Log-Backup: Tracking Issue for Removing Checkpoint V2 Codebase from TiKV Aug 1, 2022
ti-chi-bot added a commit that referenced this issue Oct 11, 2022
@YuJuncen @ti-chi-bot
log-backup: remove checkpoint V2 from codebase (#13197)
be44dba 
ref #13196

Now, all integration test cases uses checkpoint V3.
Removed `test_inflight_message` because it is invalid in V3.

Signed-off-by: Yu Juncen <yujuncen@pingcap.com>

Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement Type: Issue - Enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@YuJuncen