Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Compaction] Disable periodic compaction as default. #15355

Closed
LykxSassinator opened this issue Aug 18, 2023 · 0 comments · Fixed by #15359
Closed

[Compaction] Disable periodic compaction as default. #15355

LykxSassinator opened this issue Aug 18, 2023 · 0 comments · Fixed by #15359
Labels
affects-6.5 affects-7.1 type/enhancement Type: Issue - Enhancement

Comments

@LykxSassinator
Copy link
Contributor

Development Task

As discussed offline, we've found that upgrading to 6.5 from 6.5 and previous version will introduce extra bunch of I/Os on compaction, triggered by periodic compaction. And this compaction might last a long time, which will hurt the performance of Write and Read.
So, we wanna to disable it as default unless users who really need it.
@LykxSassinator LykxSassinator added the type/enhancement Type: Issue - Enhancement label Aug 18, 2023
@LykxSassinator LykxSassinator mentioned this issue Aug 18, 2023
Merged
ti-chi-bot bot pushed a commit that referenced this issue Aug 18, 2023
@LykxSassinator
compaction: disable periodic-compaction and ttl as default. (#15359)
cb6531f 
close #15355

Disable `periodic-compaction` and `ttl` features as default.

Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
ti-chi-bot pushed a commit to ti-chi-bot/tikv that referenced this issue Aug 18, 2023
@LykxSassinator @ti-chi-bot
This is an automated cherry-pick of tikv#15359
0216d72 
close tikv#15355

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
This was referenced Aug 18, 2023
Closed
Closed
ti-chi-bot pushed a commit to ti-chi-bot/tikv that referenced this issue Aug 18, 2023
@LykxSassinator @ti-chi-bot
This is an automated cherry-pick of tikv#15359
3511e30 
close tikv#15355

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
LykxSassinator added a commit to LykxSassinator/tikv that referenced this issue Aug 21, 2023
@LykxSassinator
[cherry-pick-v6.5]compaction: disable periodic-compaction and ttl as …
3c5d36a 
…default. (tikv#15359)

close tikv#15355

Disable `periodic-compaction` and `ttl` features as default.

Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
@LykxSassinator LykxSassinator mentioned this issue Aug 21, 2023
Merged
LykxSassinator added a commit to LykxSassinator/tikv that referenced this issue Aug 21, 2023
@LykxSassinator
[cherry-pick-v7.1]compaction: disable periodic-compaction and ttl as …
84411b4 
…default. (tikv#15359)

close tikv#15355

Disable `periodic-compaction` and `ttl` features as default.

Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
@LykxSassinator LykxSassinator mentioned this issue Aug 21, 2023
Merged
ti-chi-bot bot pushed a commit that referenced this issue Aug 21, 2023
@LykxSassinator
[cherry-pick-v6.5]compaction: disable periodic-compaction and ttl as …
4db2858 
…default. (#15359) (#15364)

close #15355

Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
ti-chi-bot bot pushed a commit that referenced this issue Aug 21, 2023
@LykxSassinator
[cherry-pick-v7.1]compaction: disable periodic-compaction and ttl as …
f455905 
…default. (#15359) (#15365)

close #15355

Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-6.5 affects-7.1 type/enhancement Type: Issue - Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

compaction: disable periodic-compaction and ttl as default. LykxSassinator/tikv
2 participants
@tonyxuqqi @LykxSassinator