Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The applys count of memory trace keeps growing #15371

Closed
Connor1996 opened this issue Aug 21, 2023 · 1 comment · Fixed by #15372
Closed

The applys count of memory trace keeps growing #15371

Connor1996 opened this issue Aug 21, 2023 · 1 comment · Fixed by #15372

Comments

@Connor1996
Copy link
Member

Bug Report

What version of TiKV are you using?

master

What operating system and CPU are you using?

Not related

Steps to reproduce

What did you expect?

The applys count of memory trace keeps growing when merging and spliting regions back and forth.

What did happened?

截屏2023-08-21 15 44 31
@Connor1996 Connor1996 added the type/bug Type: Issue - Confirmed a bug label Aug 21, 2023
Connor1996 added a commit to Connor1996/tikv that referenced this issue Aug 21, 2023
Signed-off-by: Connor1996 <zbk602423539@gmail.com>
ti-chi-bot bot pushed a commit that referenced this issue Aug 23, 2023
close #15371

Fix incorrect raftstore applys memory trace. When performing dropping apply fsm, it should reset the 
memory trace to zero instead of calling `update_memory_trace`, otherwise it would record extra footage
of the interior vector capacity.

Signed-off-by: Connor1996 <zbk602423539@gmail.com>

Co-authored-by: tonyxuqqi <tonyxuqi@outlook.com>
Connor1996 added a commit to Connor1996/tikv that referenced this issue Aug 25, 2023
close tikv#15371

Fix incorrect raftstore applys memory trace. When performing dropping apply fsm, it should reset the 
memory trace to zero instead of calling `update_memory_trace`, otherwise it would record extra footage
of the interior vector capacity.

Signed-off-by: Connor1996 <zbk602423539@gmail.com>

Co-authored-by: tonyxuqqi <tonyxuqi@outlook.com>
@tonyxuqqi
Copy link
Contributor

tonyxuqqi commented Sep 27, 2023

/cherry-pick release-7.1

ti-chi-bot pushed a commit to ti-chi-bot/tikv that referenced this issue Oct 12, 2023
Signed-off-by: Connor1996 <zbk602423539@gmail.com>
ti-chi-bot bot added a commit that referenced this issue Oct 12, 2023
close #15371

Fix incorrect raftstore applys memory trace. When performing dropping apply fsm, it should reset the 
memory trace to zero instead of calling `update_memory_trace`, otherwise it would record extra footage
of the interior vector capacity.

Signed-off-by: Connor1996 <zbk602423539@gmail.com>

Co-authored-by: Connor1996 <zbk602423539@gmail.com>
Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
ti-chi-bot pushed a commit to ti-chi-bot/tikv that referenced this issue Nov 27, 2023
Signed-off-by: Connor1996 <zbk602423539@gmail.com>
ti-chi-bot bot added a commit that referenced this issue Nov 27, 2023
close #15371

Fix incorrect raftstore applys memory trace. When performing dropping apply fsm, it should reset the 
memory trace to zero instead of calling `update_memory_trace`, otherwise it would record extra footage
of the interior vector capacity.

Signed-off-by: Connor1996 <zbk602423539@gmail.com>

Co-authored-by: Connor1996 <zbk602423539@gmail.com>
Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants