Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

can't dynamic adjust rocksdb background_compaction threads #15424

Closed
glorv opened this issue Aug 24, 2023 · 0 comments · Fixed by #15425
Closed

can't dynamic adjust rocksdb background_compaction threads #15424

glorv opened this issue Aug 24, 2023 · 0 comments · Fixed by #15425
Labels
severity/minor type/bug Type: Issue - Confirmed a bug

Comments

@glorv
Copy link
Contributor

glorv commented Aug 24, 2023

Bug Report

What version of TiKV are you using?

What operating system and CPU are you using?

Steps to reproduce

rocksdb uses max_background_flushes and max_background_compactions to control the background thread pool size, see:

https://github.com/tikv/rocksdb/blob/fe76937087f81e95a323bbf00fcd109c7b39c649/db/db_impl/db_impl_compaction_flush.cc#L2582-L2605

While in tikv, we only support set max_background_jobs and max_background_flushes, and then calculate max_background_compactions by max_background_jobs - max_background_flushes. But in DBConfigManager, max_background_compactions is not updated when max_background_jobs or max_background_flushes changes.

What did you expect?

What did happened?
@glorv glorv added type/bug Type: Issue - Confirmed a bug severity/minor labels Aug 24, 2023
@glorv glorv mentioned this issue Aug 24, 2023
Merged
ti-chi-bot bot added a commit that referenced this issue Aug 28, 2023
@glorv @ti-chi-bot
config: support changed adjust max-background-compactions dynamically (…
f3b5bf5 
…#15425)

close #15424

Signed-off-by: glorv <glorvs@163.com>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
severity/minor type/bug Type: Issue - Confirmed a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

config: support changed adjust max-background-compactions dynamically glorv/tikv
1 participant
@glorv