Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A universal issue for chore tasks #15990

Open
Connor1996 opened this issue Nov 15, 2023 · 1 comment
Open

A universal issue for chore tasks #15990

Connor1996 opened this issue Nov 15, 2023 · 1 comment
Labels
type/enhancement Type: Issue - Enhancement

Comments

@Connor1996
Copy link
Member

Connor1996 commented Nov 15, 2023 •
edited

Development Task

Include fixing typos, adding comments, refactoring code, etc.
@Connor1996 Connor1996 added the type/enhancement Type: Issue - Enhancement label Nov 15, 2023
@Connor1996 Connor1996 mentioned this issue Nov 15, 2023
Merged
ti-chi-bot bot added a commit that referenced this issue Nov 15, 2023
@0o001 @tabokie @ti-chi-bot
chore: fix error message typo (#15363)
26f36d4 
ref #15990

fix error message typo

Co-authored-by: Xinye Tao <xy.tao@outlook.com>
Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
@tonyxuqqi
Copy link
Contributor

It could be great if it can be done by rust lint

@Connor1996 Connor1996 changed the title A universe issue for typo refinement A universe issue for chore tasks Nov 30, 2023
@Connor1996 Connor1996 mentioned this issue Nov 30, 2023
Merged
9 tasks
@Connor1996 Connor1996 changed the title A universe issue for chore tasks A universal issue for chore tasks Nov 30, 2023
ti-chi-bot bot added a commit that referenced this issue Nov 30, 2023
@Connor1996 @ti-chi-bot
chore: Use checkbox for check list in pull request template (#16104)
cd5c18c 
close #15990

Use checkbox for check list in pull request template

Signed-off-by: Connor <zbk602423539@gmail.com>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
@Connor1996 Connor1996 reopened this Nov 30, 2023
@overvenus overvenus mentioned this issue Nov 30, 2023
Merged
1 task
ti-chi-bot bot added a commit that referenced this issue Nov 30, 2023
@overvenus @ti-chi-bot
metrics/grafana: set shared crosshair tooltip (#16106)
98d83f4 
ref #15990

Set shared crosshair tooltip for tikv_detail dashboard

Signed-off-by: Neil Shen <overvenus@gmail.com>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
@overvenus overvenus mentioned this issue Dec 4, 2023
Closed
1 task
@YuJuncen YuJuncen mentioned this issue Dec 29, 2023
Merged
4 tasks
ti-chi-bot bot pushed a commit that referenced this issue Jan 5, 2024
@YuJuncen @iosmanthus
log-backup: fix a typo (#16257)
df108bf 
ref #15990

Renamed Router::udpate_config to Router::update_config.

Signed-off-by: hillium <yujuncen@pingcap.com>

Co-authored-by: iosmanthus <dengliming@pingcap.com>
@overvenus overvenus mentioned this issue Jan 8, 2024
Merged
1 task
@glorv glorv mentioned this issue Jan 11, 2024
Merged
9 tasks
ti-chi-bot bot added a commit that referenced this issue Jan 12, 2024
@glorv @ti-chi-bot
test: fix unstable test test_limit_concurrency (#16361)
d5cb209 
ref #15990

The original test use select! to check t1 is finished before t2, but this is unstable when the select! is called when both t1 and t2 is finished. From the rust doc we can see " If multiple futures are ready, one will be pseudo-randomly selected at runtime."
which means if both future is ready, which is polled first is not determined. So this PR uses a atomic value to determine t1's complete to make the result stable.

Signed-off-by: glorv <glorvs@163.com>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
pingandb pushed a commit to pingandb/tikv that referenced this issue Jan 18, 2024
@YuJuncen @iosmanthus @pingandb
log-backup: fix a typo (tikv#16257)
4e5f09c 
ref tikv#15990

Renamed Router::udpate_config to Router::update_config.

Signed-off-by: hillium <yujuncen@pingcap.com>

Co-authored-by: iosmanthus <dengliming@pingcap.com>
Signed-off-by: pingandb <songge102@pingan.com.cn>
pingandb pushed a commit to pingandb/tikv that referenced this issue Jan 18, 2024
@glorv @ti-chi-bot @pingandb
test: fix unstable test test_limit_concurrency (tikv#16361)
011fae5 
ref tikv#15990

The original test use select! to check t1 is finished before t2, but this is unstable when the select! is called when both t1 and t2 is finished. From the rust doc we can see " If multiple futures are ready, one will be pseudo-randomly selected at runtime."
which means if both future is ready, which is polled first is not determined. So this PR uses a atomic value to determine t1's complete to make the result stable.

Signed-off-by: glorv <glorvs@163.com>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Signed-off-by: pingandb <songge102@pingan.com.cn>
@Connor1996 Connor1996 mentioned this issue Jan 23, 2024
Merged
9 tasks
ti-chi-bot bot pushed a commit that referenced this issue Jan 24, 2024
@Connor1996
grafana: Refine the order of grafana dashboard to localize related pa…
fe15ec2 
…nels (#16432)

ref #15990

Refine the order of grafana dashboard to localize related panels

Signed-off-by: Connor1996 <zbk602423539@gmail.com>
@SpadeA-Tang SpadeA-Tang mentioned this issue Feb 27, 2024
Merged
9 tasks
ti-chi-bot bot pushed a commit that referenced this issue Feb 27, 2024
@SpadeA-Tang
*: fix make dist_release compile fail (#16566)
544f710 
ref #15990

update skiplist-rs to make make dist_release compile fail

Signed-off-by: SpadeA-Tang <u6748471@anu.edu.au>
@Connor1996 Connor1996 mentioned this issue Mar 1, 2024
Closed
9 tasks
@overvenus overvenus mentioned this issue Mar 5, 2024
Merged
ti-chi-bot bot pushed a commit that referenced this issue Mar 5, 2024
@overvenus
*: remove cloud aws gcp azure features (#16602)
a0f8373 
ref #15990

Remove unnecessary "cloud-aws", "cloud-gcp", and "cloud-azure"
features that are always enabled in the build. No build disables
them, rendering them as useless features.

Signed-off-by: Neil Shen <overvenus@gmail.com>
@overvenus overvenus mentioned this issue Mar 7, 2024
Merged
ti-chi-bot bot added a commit that referenced this issue Mar 11, 2024
@overvenus @ti-chi-bot
sst_importer: replace mem_limit with MemoryQuota (#16618)
6c3c1ce 
ref #15990

Signed-off-by: Neil Shen <overvenus@gmail.com>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
dbsid pushed a commit to dbsid/tikv that referenced this issue Mar 24, 2024
@Connor1996 @dbsid
grafana: Refine the order of grafana dashboard to localize related pa…
a8ac9f6 
…nels (tikv#16432)

ref tikv#15990

Refine the order of grafana dashboard to localize related panels

Signed-off-by: Connor1996 <zbk602423539@gmail.com>
Signed-off-by: dbsid <chenhuansheng@pingcap.com>
dbsid pushed a commit to dbsid/tikv that referenced this issue Mar 24, 2024
@SpadeA-Tang @dbsid
*: fix make dist_release compile fail (tikv#16566)
3d4e5cb 
ref tikv#15990

update skiplist-rs to make make dist_release compile fail

Signed-off-by: SpadeA-Tang <u6748471@anu.edu.au>
Signed-off-by: dbsid <chenhuansheng@pingcap.com>
dbsid pushed a commit to dbsid/tikv that referenced this issue Mar 24, 2024
@overvenus @dbsid
*: remove cloud aws gcp azure features (tikv#16602)
1cbb1a3 
ref tikv#15990

Remove unnecessary "cloud-aws", "cloud-gcp", and "cloud-azure"
features that are always enabled in the build. No build disables
them, rendering them as useless features.

Signed-off-by: Neil Shen <overvenus@gmail.com>
Signed-off-by: dbsid <chenhuansheng@pingcap.com>
dbsid pushed a commit to dbsid/tikv that referenced this issue Mar 24, 2024
@overvenus @ti-chi-bot @dbsid
sst_importer: replace mem_limit with MemoryQuota (tikv#16618)
76832cd 
ref tikv#15990

Signed-off-by: Neil Shen <overvenus@gmail.com>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Signed-off-by: dbsid <chenhuansheng@pingcap.com>
@Connor1996 Connor1996 mentioned this issue Apr 7, 2024
Merged
9 tasks
ti-chi-bot bot added a commit that referenced this issue Apr 8, 2024
@Connor1996 @ti-chi-bot
raftstore: Avoid consuming resource when there is only one resource g…
7b0e224 
…roup (#16775)

ref #15990

Avoid consuming resource when there is only one resource group

Signed-off-by: Connor1996 <zbk602423539@gmail.com>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
@glorv glorv mentioned this issue Apr 9, 2024
Merged
9 tasks
ti-chi-bot bot added a commit that referenced this issue Apr 10, 2024
@glorv @ti-chi-bot
test: enhance flaky test disk_snap::test_conf_change (#16785)
cc1376f 
ref #15990

Enhance unittest disk_snap::test_conf_change by add a timeout to allow async_remove_peer wait for raft replication ready.

Signed-off-by: glorv <glorvs@163.com>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
@glorv glorv mentioned this issue Apr 11, 2024
Closed
9 tasks
@3pointer 3pointer mentioned this issue Apr 29, 2024
Merged
9 tasks
@glorv glorv mentioned this issue Apr 30, 2024
Merged
9 tasks
ti-chi-bot bot pushed a commit that referenced this issue May 7, 2024
@3pointer
metrics: fix the typo of metrics (#16931)
c36886a 
ref #15990

metrics: fix the typo of metrics

Signed-off-by: 3pointer <luancheng@pingcap.com>
ti-chi-bot bot pushed a commit that referenced this issue May 8, 2024
@glorv
tikv_util: make memory quota alloc and free simpler (#16938)
3c4358f 
ref #15990

Replace `compare_exchange_weak` loop with single `fetch_add` and `fetch_sub` to make the memory alloc and free simpler.
I do this change base on the fact that we does not expect the memory control to be precise on every operation. In high concurrency scenario and when the conflict is heavy, the real peak memory usage may be small than the capacity, but not smaller than `capacity - num_of_concurrency * avg_alloc_bytes`.

NOTE: In order to avoid counter overflow, this change introduces a hard limit(256PiB) that one alloc can acquire as it's big enough for any real world application. Passing higher value to `alloc` will result in an error, passing higher value to `alloc_force` and `free` will result in noop.

Signed-off-by: glorv <glorvs@163.com>
@glorv glorv mentioned this issue May 13, 2024
Open
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement Type: Issue - Enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tonyxuqqi @Connor1996