Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tikv-ctl compact-cluster doesn't work when TiFlash nodes exist #16189

Closed
frew opened this issue Dec 17, 2023 · 1 comment · Fixed by #16190
Closed

tikv-ctl compact-cluster doesn't work when TiFlash nodes exist #16189

frew opened this issue Dec 17, 2023 · 1 comment · Fixed by #16190
Labels
affects-5.4 affects-6.0 affects-6.1 affects-6.2 affects-6.3 affects-6.4 affects-6.5 affects-6.6 affects-7.0 affects-7.1 affects-7.2 affects-7.3 affects-7.4 affects-7.5 affects-7.6 severity/critical type/bug Type: Issue - Confirmed a bug

Comments

@frew
Copy link
Contributor

frew commented Dec 17, 2023

Bug Report

What version of TiKV are you using?

7.1.1

What operating system and CPU are you using?

Steps to reproduce

Create cluster with a TiFlash node. Run tikv-ctl compact-cluster.

What did you expect?

compact-cluster to finish successfully

What did happened?

DebugClient::compact: RpcFailure: 12-UNIMPLEMENTED

Note: I have a PR for this coming shortly.
@frew frew added the type/bug Type: Issue - Confirmed a bug label Dec 17, 2023
@frew frew mentioned this issue Dec 17, 2023
Merged
1 task
ti-chi-bot bot pushed a commit that referenced this issue Jan 10, 2024
@frew @tonyxuqqi
tikv-ctl: Don't send compact commands to TiFlash stores (#16190)
c041ee3 
close #16189

tikv-ctl compact-cluster now works with clusters that have TiFlash nodes

Signed-off-by: Fred Wulff <frew@cs.stanford.edu>

Co-authored-by: tonyxuqqi <tonyxuqi@outlook.com>
This was referenced Jan 10, 2024
Open
Merged
This was referenced Jan 10, 2024
Merged
Merged
Open
@tonyxuqqi
Copy link
Contributor

/cherry-pick release-7.6

@ti-chi-bot ti-chi-bot mentioned this issue Jan 11, 2024
Merged
1 task
ti-chi-bot bot pushed a commit that referenced this issue Jan 11, 2024
@ti-chi-bot @frew
tikv-ctl: Don't send compact commands to TiFlash stores (#16190) (#16358
737daff 
)

close #16189

tikv-ctl compact-cluster now works with clusters that have TiFlash nodes

Signed-off-by: Fred Wulff <frew@cs.stanford.edu>

Co-authored-by: Fred Wulff <frew@cs.stanford.edu>
pingandb pushed a commit to pingandb/tikv that referenced this issue Jan 18, 2024
@frew @tonyxuqqi @pingandb
tikv-ctl: Don't send compact commands to TiFlash stores (tikv#16190)
2621797 
close tikv#16189

tikv-ctl compact-cluster now works with clusters that have TiFlash nodes

Signed-off-by: Fred Wulff <frew@cs.stanford.edu>

Co-authored-by: tonyxuqqi <tonyxuqi@outlook.com>
Signed-off-by: pingandb <songge102@pingan.com.cn>
ti-chi-bot bot added a commit that referenced this issue Jan 23, 2024
@ti-chi-bot @tonyxuqqi @ti-chi-bot
tikv-ctl: Don't send compact commands to TiFlash stores (#16190) (#16348
7775b8c 
)

close #16189

tikv-ctl compact-cluster now works with clusters that have TiFlash nodes

Co-authored-by: tonyxuqqi <tonyxuqi@outlook.com>
Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
ti-chi-bot bot pushed a commit that referenced this issue Feb 2, 2024
@ti-chi-bot @frew @tonyxuqqi
tikv-ctl: Don't send compact commands to TiFlash stores (#16190) (#16350
2ec454f 
)

close #16189

tikv-ctl compact-cluster now works with clusters that have TiFlash nodes

Signed-off-by: Fred Wulff <frew@cs.stanford.edu>

Co-authored-by: Fred Wulff <frew@cs.stanford.edu>
Co-authored-by: tonyxuqqi <tonyxuqi@outlook.com>
ti-chi-bot bot pushed a commit that referenced this issue Feb 26, 2024
@ti-chi-bot @frew @tonyxuqqi
tikv-ctl: Don't send compact commands to TiFlash stores (#16190) (#16349
863cdd5 
)

close #16189

tikv-ctl compact-cluster now works with clusters that have TiFlash nodes

Signed-off-by: Fred Wulff <frew@cs.stanford.edu>

Co-authored-by: Fred Wulff <frew@cs.stanford.edu>
Co-authored-by: tonyxuqqi <tonyxuqi@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-5.4 affects-6.0 affects-6.1 affects-6.2 affects-6.3 affects-6.4 affects-6.5 affects-6.6 affects-7.0 affects-7.1 affects-7.2 affects-7.3 affects-7.4 affects-7.5 affects-7.6 severity/critical type/bug Type: Issue - Confirmed a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tikv-ctl: Don't send compact commands to TiFlash stores frew/tikv
5 participants
@frew @jebter @tonyxuqqi @Connor1996 @ti-chi-bot