Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why the dist_release task needs compile the test pkgs? #16501

Closed
wuhuizuo opened this issue Feb 5, 2024 · 0 comments · Fixed by #16506
Closed

Why the dist_release task needs compile the test pkgs? #16501

wuhuizuo opened this issue Feb 5, 2024 · 0 comments · Fixed by #16506
Labels
type/question Type: Issue - Question

Comments

@wuhuizuo
Copy link
Contributor

wuhuizuo commented Feb 5, 2024 •
edited

Question

I run the command:

ROCKSDB_SYS_STATIC=1 make dist_release

But I found it compiled some test packages, I think there are no need to contain the test package when building a release binary:
image
@wuhuizuo wuhuizuo added the type/question Type: Issue - Question label Feb 5, 2024
@wuhuizuo wuhuizuo changed the title why the dist_release task needs compile the test pkgs? Why the dist_release task needs compile the test pkgs? Feb 5, 2024
@LykxSassinator LykxSassinator mentioned this issue Feb 6, 2024
Merged
9 tasks
ti-chi-bot bot pushed a commit that referenced this issue Feb 6, 2024
@LykxSassinator
*: tidy the dependencies on test crates. (#16506)
7a18bac 
close #16501

By introducing this pr, the unnecessary compilation on test crates when
building the release output can be ignored.

Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
dbsid pushed a commit to dbsid/tikv that referenced this issue Mar 24, 2024
@LykxSassinator @dbsid
*: tidy the dependencies on test crates. (tikv#16506)
f704924 
close tikv#16501

By introducing this pr, the unnecessary compilation on test crates when
building the release output can be ignored.

Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
Signed-off-by: dbsid <chenhuansheng@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/question Type: Issue - Question
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

*: tidy the dependencies on test crates. LykxSassinator/tikv
1 participant
@wuhuizuo