Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tikv does not handle ambiguous time zones correctly #3721

Closed
morgo opened this issue Oct 28, 2018 · 3 comments · Fixed by #3786
Closed

tikv does not handle ambiguous time zones correctly #3721

morgo opened this issue Oct 28, 2018 · 3 comments · Fixed by #3786
Labels
type/bug The issue is confirmed as a bug.

Comments

@morgo
Copy link

morgo commented Oct 28, 2018

Bug Report

What version of Rust are you using?

N/A. Using a binary.

What operating system and CPU are you using?

Debian / Intel

What did you do?

Using the bikeshare sample database for TiDB:

mysql> delete from trips where start_date < '2017-01-01 00:00:00';
ERROR 1105 (HY000): other error: unknown error StringError("[src/coprocessor/dag/executor/mod.rs:239]: unknown error StringError(\"[src/coprocessor/codec/mysql/time/mod.rs:95]: \\\'2010-11-7 1:0:8.000000000\\\' is not a valid datetime\")")

What did you expect to see?

Success.

What did you see instead?

In pingcap/tidb#7768 @breeswish confirmed that this issue is related to time zones. I see it as a common issue, since anyone with a system time that has DST could experience it at some point.

@breezewish
Copy link
Member

Thanks a lot for reporting. This is a known issue and we don't have a near plan to fix it. Let's keep this issue open so that others will know.

@morgo
Copy link
Author

morgo commented Nov 1, 2018

Thanks @breeswish. For TiDB, we will have to consider how to document it. It might be worth putting it on the MySQL Compatibility page.

@ice1000 ice1000 added the type/bug The issue is confirmed as a bug. label Nov 1, 2018
@breezewish
Copy link
Member

breezewish commented Nov 2, 2018

@morgo Right. I planned to do it but forgot it 🤣 Thanks a lot for your issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug The issue is confirmed as a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants