Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade jemalloc to v0.3 #4406

Open
brson opened this issue Mar 20, 2019 · 2 comments
Open

Upgrade jemalloc to v0.3 #4406

brson opened this issue Mar 20, 2019 · 2 comments
Assignees
Labels
component/performance Component: Performance component/server Component: Server help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. priority/high Priority: High status/mentor This issue is currently mentored

Comments

@brson
Copy link
Contributor

brson commented Mar 20, 2019

Edit: A new version of jemallocator has been released. The task here is to upgrade jemalloc, jemalloc-sys, and jemalloc-ctl.

Should wait until after #4416 (comment) lands.


I've only just discovered that jemallocator/master is at version 0.3.0, but the latest jemallocator crate (the one we are linking to) is only at 0.1.9 and was published last July.

When I did the toolchain upgrade that refactored our jemalloc code I moved from @BusyJay's fork (I think) to the published version. I could have reverted jemallocator progress by doing so.

So maybe the published versions of jemallocator are deprecated. Not sure. I've asked here.

We may need to change the dependency back to a git revision.

I marked this high priority because I think it is a release blocker to be on the "wrong" version of our allocator.

@brson brson added component/performance Component: Performance priority/high Priority: High component/server Component: Server labels Mar 20, 2019
@brson
Copy link
Contributor Author

brson commented Mar 26, 2019

jemallocator v0.3 is released

@brson brson changed the title Use git version of jemallocator? Upgrade jemalloc to v0.3 Mar 26, 2019
@brson brson added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. status/mentor This issue is currently mentored labels Mar 26, 2019
@brson
Copy link
Contributor Author

brson commented Apr 3, 2019

jemalloc-ctl, which we depend on, still hasn't been updated for 0.3. I've been testing the pre-release version and will push to get it published.

@brson brson self-assigned this Apr 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/performance Component: Performance component/server Component: Server help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. priority/high Priority: High status/mentor This issue is currently mentored
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant