New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cdc: back pressure scan speed (#10142) #10151
cdc: back pressure scan speed (#10142) #10151
Conversation
/run-all-tests |
@overvenus you're already a collaborator in bot's repo. |
* cdc: limit max pending sent scan events Signed-off-by: Neil Shen <overvenus@gmail.com> * cdc/channel: add tests Signed-off-by: Neil Shen <overvenus@gmail.com> * cdc: add grpc flow control test Signed-off-by: Neil Shen <overvenus@gmail.com> * cdc: add panic message details Signed-off-by: Neil Shen <overvenus@gmail.com> * cdc: add send_all for Sink Signed-off-by: Neil Shen <overvenus@gmail.com> * clean up Signed-off-by: Neil Shen <overvenus@gmail.com> * cdc: handle sink error Signed-off-by: Neil Shen <overvenus@gmail.com> * cdc: correct comments Signed-off-by: Neil Shen <overvenus@gmail.com> * cdc: rename Congest to Congested Signed-off-by: Neil Shen <overvenus@gmail.com> * cdc: deregister region when resolver fails to build Signed-off-by: Neil Shen <overvenus@gmail.com> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io> Signed-off-by: Neil Shen <overvenus@gmail.com>
Signed-off-by: Neil Shen <overvenus@gmail.com> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
e33041a
to
ef04d56
Compare
Signed-off-by: Neil Shen <overvenus@gmail.com>
Signed-off-by: Neil Shen <overvenus@gmail.com>
/run-test test_region_heartbeat_report_approximate_size fails. |
/run-test test_region_heartbeat_report_approximate_size fails |
Signed-off-by: Neil Shen <overvenus@gmail.com>
Signed-off-by: Neil Shen <overvenus@gmail.com>
Signed-off-by: Neil Shen <overvenus@gmail.com>
Signed-off-by: Neil Shen <overvenus@gmail.com>
components/cdc/src/delegate.rs
Outdated
where | ||
F: Fn(&Downstream) -> Result<()>, | ||
{ | ||
// fn broadcast(&self, change_data_event: Event, normal_only: bool) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// fn broadcast(&self, change_data_event: Event, normal_only: bool) { |
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
Signed-off-by: Neil Shen <overvenus@gmail.com>
/merge |
@overvenus: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 3070b48
|
@ti-srebot: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
cherry-pick #10142 to release-5.0
You can switch your code base to this Pull Request by using git-extras:
# In tikv repo: git pr https://github.com/tikv/tikv/pull/10151
After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
There will be a series of PRs aims to fix the TiKV CDC OOM issue (too many pending send messages are buffered in memory).
To resolve the issue, we have two strategies,
The series of PRs adopts both strategies.
This is part of #9885, it backpressure scan speed by replacing an unbounded channel with a bounded channel.
Also, this PR cherry-picks #10028.
Plan:
See full changes: master...overvenus:cdc/flowcontrol/all
Cc #8168 #9996
Check List
Tests
Release note