Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raftstore: skip clearing callback when shutdown (#10364) #10394

Closed

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Jun 18, 2021

cherry-pick #10364 to release-3.0
You can switch your code base to this Pull Request by using git-extras:

# In tikv repo:
git pr https://github.com/tikv/tikv/pull/10394

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tikv.git pr/10394:release-3.0-bfc3c47d3ae6

What problem does this PR solve?

Issue Number:
close #10353
close #10307

Problem Summary:

If callbacks are cleared during shutdown, latch may not work as expected
as it expects deterministic result. So this PR drops all callbacks
instead of invoking.

Check List

Tests

  • Unit test
  • Integration test

Release note

skip clearing callback during gracefully shutdown to avoid breaking ACID in some cases

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot
Copy link
Contributor Author

@BusyJay please accept the invitation then you can push to the cherry-pick pull requests.
https://github.com/ti-srebot/tikv/invitations

@VelocityLight
Copy link

This pull request is closed because it's related version has closed automatic cherry-picking.
If it's still needed, you can reopen it or just regenerate it using bot,
see:

You can find more details at:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note size/XXL type/bugfix Type: PR - Fix a bug type/cherry-pick Type: PR - Cherry pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants