Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics: introduce a new way to dump metrics immediately #1042

Closed
wants to merge 1 commit into from

Conversation

ngaut
Copy link
Member

@ngaut ngaut commented Sep 7, 2016

Sometimes we need to dump the metrics one by one immediately, and compare those metrics. Eg: server is busy, we don't why, and we don't want to interrupt the server.

@siddontang
Copy link
Contributor

siddontang commented Sep 7, 2016

In my local Mac OS X test, I use kill -s USR1, but unluckily, program exits.

@ngaut
Copy link
Member Author

ngaut commented Sep 7, 2016

Please see the comments to get the usage @siddontang

@siddontang
Copy link
Contributor

I prefer using USR1 or USR2.
If I run tikv in the foreground, I can't terminate the program with ctrl + c.

@ngaut
Copy link
Member Author

ngaut commented Sep 7, 2016

The simple-signal library doesn't support USR1, i will send a PR to fix it tomorrow.

@@ -23,6 +23,9 @@ extern crate mio;
extern crate toml;
extern crate libc;
extern crate fs2;
extern crate simple_signal;
extern crate prometheus;

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove empty line 28.

@siddontang
Copy link
Contributor

This PR seems old and #1071 does the same thing, I will close it.

@siddontang siddontang closed this Sep 16, 2016
@ngaut ngaut deleted the ngaut/metrics-dump-signal branch September 26, 2016 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants