Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Fix build status CI badge in README #10921

Merged
merged 4 commits into from Sep 10, 2021
Merged

docs: Fix build status CI badge in README #10921

merged 4 commits into from Sep 10, 2021

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Sep 8, 2021

What problem does this PR solve?

image

What is changed and how it works?

Replaced by new CI service's badge.

Release note

None.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 8, 2021 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • BusyJay
  • sticnarf

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@Xuanwo
docs: Fix build status CI badge in README
946d7cd 
Signed-off-by: Xuanwo <github@xuanwo.io>
@ti-chi-bot
Copy link
Member

@Renkai: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

@gaocegege: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

BusyJay
BusyJay reviewed Sep 8, 2021
View reviewed changes
README.md Outdated Show resolved Hide resolved
@Xuanwo
Address comments
89a7784 
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
Copy link
Member Author

Xuanwo commented Sep 8, 2021

/cc @BusyJay @zhouqiang-cl

PTAL

@Xuanwo
Copy link
Member Author

Xuanwo commented Sep 8, 2021

BTW, do we just do cargo build for this job?

BusyJay
BusyJay approved these changes Sep 9, 2021
View reviewed changes
Copy link
Member

@BusyJay BusyJay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ti-chi-bot ti-chi-bot added the status/LGT1 Status: PR - There is already 1 approval label Sep 9, 2021
@ti-chi-bot
Copy link
Member

@JmPotato: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

sticnarf
sticnarf approved these changes Sep 10, 2021
View reviewed changes
Copy link
Contributor

@sticnarf sticnarf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you very much!

@ti-chi-bot ti-chi-bot added status/LGT2 Status: PR - There are already 2 approvals and removed status/LGT1 Status: PR - There is already 1 approval labels Sep 10, 2021
@sticnarf
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

@sticnarf: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: d843a6a

@ti-chi-bot ti-chi-bot added the status/can-merge Status: Can merge to base branch label Sep 10, 2021
@ti-chi-bot
Copy link
Member

@Xuanwo: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit d377cfd into tikv:master Sep 10, 2021
@Xuanwo Xuanwo deleted the patch-1 branch September 12, 2021 03:20
daimashusheng pushed a commit to daimashusheng/tikv that referenced this pull request Sep 14, 2021
@Xuanwo @sticnarf @ti-chi-bot
docs: Fix build status CI badge in README (tikv#10921)
8e08578 
* docs: Fix build status CI badge in README

Signed-off-by: Xuanwo <github@xuanwo.io>

* Address comments

Signed-off-by: Xuanwo <github@xuanwo.io>

Co-authored-by: Yilin Chen <sticnarf@gmail.com>
Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Signed-off-by: tangjk <tangjiankun1226@gmail.com>
v01dstar pushed a commit to v01dstar/tikv that referenced this pull request Oct 26, 2021
@Xuanwo @sticnarf
@ti-chi-bot @v01dstar
docs: Fix build status CI badge in README (tikv#10921)
91198f9 
* docs: Fix build status CI badge in README

Signed-off-by: Xuanwo <github@xuanwo.io>

* Address comments

Signed-off-by: Xuanwo <github@xuanwo.io>

Co-authored-by: Yilin Chen <sticnarf@gmail.com>
Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@purelind purelind purelind left review comments

@JmPotato JmPotato JmPotato approved these changes

@BusyJay BusyJay BusyJay approved these changes

@Renkai Renkai Renkai approved these changes

@gaocegege gaocegege gaocegege approved these changes

@sticnarf sticnarf sticnarf approved these changes

@zhouqiang-cl zhouqiang-cl Awaiting requested review from zhouqiang-cl

Assignees
No one assigned
Labels
release-note-none size/XS status/can-merge Status: Can merge to base branch status/LGT2 Status: PR - There are already 2 approvals
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@Xuanwo @ti-chi-bot @sticnarf @JmPotato @BusyJay @Renkai @gaocegege @purelind @zhouqiang-cl